[Breaking] Remove shorthand for store_xids in bulk loader. #5148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manishrjain
approved these changes
Apr 9, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
ashish-goswami
approved these changes
Apr 9, 2020
There was a problem hiding this comment.
Reviewable status:
danielmai
changed the title
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 18, 2020
Remove shorthand for store_xids in bulk loader and modify bulk_live_fixture_test accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear contributor, what does this PR do?
Remove
-xshort hand forstore_xidsflag in bulk loader. Neitherstore_xidsnorxidmaphas any shortcut in bulk loader in the PR.Motivation
This is done to avoid confusion with
-xflag forxidmapin live loader. Do not want-xto stand for different actions between live loader and bulk loader.Components affected by this PR
Bulk loader
Does this PR break backwards compatibility?
Yes, it removes a shorthand flag which is present in current master.
This change is
Docs Preview: