Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid running opIndexing in case there are no schema updates #5126

Merged
merged 1 commit into from
Apr 9, 2020

Conversation

manishrjain
Copy link
Contributor

@manishrjain manishrjain commented Apr 7, 2020

If we don't have any schema updates, avoid running the indexing sequence.
Also, remove a time.Sleep.
Removes unnecessary opIndexing logs from Alpha, when we have type updates.


This change is Reviewable

@manishrjain manishrjain requested a review from a team as a code owner April 7, 2020 15:20
@manishrjain
Copy link
Contributor Author

@parasssh any ideas why the teamcity build is failing here?

@parasssh
Copy link
Contributor

parasssh commented Apr 7, 2020

Checking.

@parasssh
Copy link
Contributor

parasssh commented Apr 7, 2020

It seems some unit tests timed out. I will retrigger the CI.

@parasssh
Copy link
Contributor

parasssh commented Apr 7, 2020

CI passed now.

@animesh2049 animesh2049 merged commit 1806a36 into master Apr 9, 2020
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 18, 2020
@joshua-goldstein joshua-goldstein deleted the mrjn/avoid-indexing branch August 11, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants