Split posting lists recursively. #4867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, split posting lists are split in one go. This means that the resulting splits will be added to the list even if they are still too big. This change recursively splits the parts of the lists until all of them are smaller than the threshold.
golangcibot
reviewed
Feb 27, 2020
manishrjain
approved these changes
Mar 10, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @manishrjain and @martinmr)
posting/list.go, line 1247 at r2 (raw file):
func (out *rollupOutput) recursiveSplit() { // Call splitUpList. Otherwise the map of startUids to parts won't be initialized. out.splitUpList()
Do you need to call this here?
martinmr
commented
Mar 11, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @golangcibot and @manishrjain)
posting/list.go, line 1221 at r1 (raw file):
Previously, golangcibot (Bot from GolangCI) wrote…
File is not
gofmt-ed with-s(fromgofmt)}
Done.
posting/list.go, line 1247 at r2 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
Do you need to call this here?
Done. Simplified the logic.
martinmr
added a commit
that referenced
this pull request
Jun 12, 2020
Currently, split posting lists are split in one go. This means that the resulting splits will be added to the list even if they are still too big. This change recursively splits the parts of the lists until all of them are smaller than the threshold.
martinmr
added a commit
that referenced
this pull request
Jul 9, 2020
Currently, split posting lists are split in one go. This means that the resulting splits will be added to the list even if they are still too big. This change recursively splits the parts of the lists until all of them are smaller than the threshold.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, split posting lists are split in one go. This means that the
resulting splits will be added to the list even if they are still too
big. This change recursively splits the parts of the lists until all of
them are smaller than the threshold.
This change is
Docs Preview: