-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for MultiPolygon #1358
Support for MultiPolygon #1358
Conversation
Review status: 0 of 41 files reviewed at latest revision, 4 unresolved discussions, some commit checks failed. types/geofilter.go, line 48 at r1 (raw file):
Contains, Intersects and Within queries can now take MultiPolygons, so we change loops to be a slice. types/geofilter.go, line 225 at r1 (raw file):
We don't need this as I added a function which checks whether one loop Contains another. types/s2.go, line 32 at r1 (raw file):
Go s2 library added functions to types/s2.go, line 79 at r1 (raw file):
I picked this up from the C++ source code. Comments from Reviewable |
Reviewed 37 of 41 files at r1, 4 of 4 files at r2. types/geofilter.go, line 245 at r2 (raw file):
100 chars. types/geofilter.go, line 305 at r2 (raw file):
Can add an assert here that it shouldn't reach here. Comments from Reviewable |
Reviewed 37 of 41 files at r1, 4 of 4 files at r2. Comments from Reviewable |
Merged to master. |
This commit brings the following changes from badger c45d966 Fix assert in background compression and encryption. (#1366) 14386ac GC: Consider size of value while rewriting (#1357) b2267c2 Restore: Account for value size as well (#1358) b762832 Tests: Do not leave behind state goroutines (#1349) 056d859 Support disabling conflict detection (#1344) fd89894 Compaction: Expired keys and delete markers are never purged (#1354) 543f353 Fix build on golang tip (#1355) a7e239e StreamWriter: Close head writer (#1347) da80eb9 Iterator: Always add key to txn.reads (#1328) 7e19cac Add immudb to the project list (#1341) 079f5ae DefaultOptions: Set KeepL0InMemory to false (#1345)
This commit brings the following changes from badger ``` c45d966 Fix assert in background compression and encryption. (#1366) 14386ac GC: Consider size of value while rewriting (#1357) b2267c2 Restore: Account for value size as well (#1358) b762832 Tests: Do not leave behind state goroutines (#1349) 056d859 Support disabling conflict detection (#1344) fd89894 Compaction: Expired keys and delete markers are never purged (#1354) 543f353 Fix build on golang tip (#1355) a7e239e StreamWriter: Close head writer (#1347) da80eb9 Iterator: Always add key to txn.reads (#1328) 7e19cac Add immudb to the project list (#1341) 079f5ae DefaultOptions: Set KeepL0InMemory to false (#1345) ```
This change is