Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncaught error - when ACL feature is turned on, and login credentials not passed #71

Closed
prashant-shahi opened this issue Sep 12, 2019 · 2 comments
Closed

Uncaught error - when ACL feature is turned on, and login credentials not passed #71

prashant-shahi opened this issue Sep 12, 2019 · 2 comments
Assignees
@prashant-shahi
Labels
kind/bug Something is broken. kind/enhancement Something could be better.

Comments

@prashant-shahi
Copy link
Contributor

When I ran the example script against dgraph cluster with ACL feature turned on, I encountered the following error, which wasn't of much help.

ERROR:  TypeError: Cannot read property 'serializeBinary' of undefined
    at Object.createPayload (/Users/prashant/dgraph-code/dgraph-js/examples/v1.1/node_modules/dgraph-js/lib/types.js:65:105)
    at DgraphClient.<anonymous> (/Users/prashant/dgraph-code/dgraph-js/examples/v1.1/node_modules/dgraph-js/lib/client.js:86:36)
    at step (/Users/prashant/dgraph-code/dgraph-js/examples/v1.1/node_modules/dgraph-js/lib/client.js:32:23)
    at Object.throw (/Users/prashant/dgraph-code/dgraph-js/examples/v1.1/node_modules/dgraph-js/lib/client.js:13:53)
    at rejected (/Users/prashant/dgraph-code/dgraph-js/examples/v1.1/node_modules/dgraph-js/lib/client.js:5:65)

Meanwhile, we need to have more tests around ACL as well.
@prashant-shahi prashant-shahi added kind/bug Something is broken. kind/enhancement Something could be better. and removed kind/bug Something is broken. labels Sep 13, 2019
@prashant-shahi
Copy link
Contributor Author

Even when the Dgraph cluster is not properly up and running, or invalid gRPC address is used, the same issue was encountered.

@prashant-shahi prashant-shahi mentioned this issue Sep 13, 2019
Closed
prashant-shahi added a commit that referenced this issue Sep 18, 2019
@prashant-shahi
Bug fix (#71)
6171b2d 
- When refreshing jwt token, throw caught exceptions.
@prashant-shahi prashant-shahi mentioned this issue Sep 18, 2019
Merged
prashant-shahi added a commit that referenced this issue Sep 19, 2019
@prashant-shahi
Throwing caught exceptions during JWT token refresh (#77)
3e3a0b2 
* Bug fix (#71)

- When refreshing JWT token, throw caught exceptions.

* Adding generated files

* Fixing payload types
@prashant-shahi
Copy link
Contributor Author

Turns out this issue also happens when an invalid schema is passed.

It will be resolved with the release of v2.0.2.

@prashant-shahi prashant-shahi self-assigned this Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prashant-shahi prashant-shahi

Labels
kind/bug Something is broken. kind/enhancement Something could be better.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@prashant-shahi