Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated metrics name #1982

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Updated metrics name #1982

merged 2 commits into from
Jul 31, 2023

Conversation

harshil-goel
Copy link
Contributor

Fix go lint issue

mangalaman93
mangalaman93 reviewed Jul 31, 2023
View reviewed changes
Copy link
Contributor

@mangalaman93 mangalaman93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, now we don't need to worry about the problem when importing two different versions of badger?

@mangalaman93 mangalaman93 merged commit c2e611a into main Jul 31, 2023
6 checks passed
@mangalaman93 mangalaman93 deleted the harshil/fix-metricas branch July 31, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mangalaman93 mangalaman93 mangalaman93 approved these changes

@akon-dey akon-dey Awaiting requested review from akon-dey

@billprovince billprovince Awaiting requested review from billprovince

@joshua-goldstein joshua-goldstein Awaiting requested review from joshua-goldstein

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshil-goel @mangalaman93