fix(Test): BenchmarkDbGrowth #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SpadeA-Tang <[email protected]>
SpadeA-Tang
requested review from
akon-dey,
billprovince and
joshua-goldstein
as code owners
|
|
mangalaman93
approved these changes
Jun 7, 2023
|
Would you mind helping me to merge this? @mangalaman93 |
|
Thanks for the PR @SpadeA-Tang |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It seems some parameter settings have been changed in the past. As a result, some tests (at least one) lose the ability to test what they want to test.
For
BenchmarkDbGrowth, current default value ofValueThresholdmakes no vlog will be created and current default value ofMemTableSizemakes no memtable will be flushed which means no compaction and thus no vlog gc will be performed.Solution
Setting
ValueThresholdbe 1024 andMemTableSizebe 1MB in this case seems to be fine.