chore(tests): unbreak tests on Windows

db2_test.go

@@ -685,7 +685,7 @@ func TestWindowsDataLoss(t *testing.T) {
 		err := db.Update(func(txn *Txn) error {
 			key := []byte(fmt.Sprintf("%d", i))
 			v := []byte("barValuebarValuebarValuebarValuebarValue")
-			require.Greater(t, len(v), db.valueThreshold())
+			require.Greater(t, int64(len(v)), db.valueThreshold())
 
 			//32 bytes length and now it's not working
 			err := txn.Set(key, v)
@@ -710,6 +710,7 @@ func TestWindowsDataLoss(t *testing.T) {
 	// Don't use vlog.Close here. We don't want to fix the file size. Only un-mmap
 	// the data so that we can truncate the file durning the next vlog.Open.
 	require.NoError(t, z.Munmap(db.vlog.filesMap[db.vlog.maxFid].Data))
+	require.NoError(t, db.mt.wal.Close(-1))
 	for _, f := range db.vlog.filesMap {
 		require.NoError(t, f.Fd.Close())
 	}

db_test.go

@@ -2234,11 +2234,13 @@ func TestOpenDBReadOnly(t *testing.T) {
 
 	ops.ReadOnly = true
 	db, err = Open(ops)
-	require.NoError(t, err)
-	require.NoError(t, db.Close())
+	if runtime.GOOS == "windows" {
+		require.Equal(t, err, ErrWindowsNotSupported)
+	} else {
+		require.NoError(t, err)
+		require.NoError(t, db.Close())
+	}
 
-	db, err = Open(ops)
-	require.NoError(t, err)
 	var count int
 	read := func() {
 		count = 0
@@ -2256,9 +2258,13 @@ func TestOpenDBReadOnly(t *testing.T) {
 			return nil
 		})
 	}
-	read()
-	require.Equal(t, 10, count)
-	require.NoError(t, db.Close())
+	if runtime.GOOS != "windows" {
+		db, err = Open(ops)
+		require.NoError(t, err)
+		read()
+		require.Equal(t, 10, count)
+		require.NoError(t, db.Close())
+	}
 
 	ops.ReadOnly = false
 	db, err = Open(ops)
@@ -2279,10 +2285,14 @@ func TestOpenDBReadOnly(t *testing.T) {
 
 	ops.ReadOnly = true
 	db, err = Open(ops)
-	require.NoError(t, err)
-	read()
-	require.Equal(t, 20, count)
-	require.NoError(t, db.Close())
+	if runtime.GOOS == "windows" {
+		require.Equal(t, err, ErrWindowsNotSupported)
+	} else {
+		require.NoError(t, err)
+		read()
+		require.Equal(t, 20, count)
+		require.NoError(t, db.Close())
+	}
 }
 
 func TestBannedPrefixes(t *testing.T) {

iterator_test.go

@@ -24,6 +24,7 @@ import (
 	"math/rand"
 	"os"
 	"path/filepath"
+	"runtime"
 	"strings"
 	"testing"
 
@@ -303,6 +304,11 @@ func TestIteratorReadOnlyWithNoData(t *testing.T) {
 
 	opts.ReadOnly = true
 	db, err = Open(opts)
+	if runtime.GOOS == "windows" {
+		require.Equal(t, err, ErrWindowsNotSupported)
+		return
+	}
+
 	require.NoError(t, err)
 	defer func() {
 		require.NoError(t, db.Close())

pb/protos_test.go

@@ -17,6 +17,7 @@ package pb
 
 import (
 	"os/exec"
+	"runtime"
 	"testing"
 
 	"github.com/stretchr/testify/require"
@@ -32,6 +33,9 @@ func Exec(argv ...string) error {
 }
 
 func TestProtosRegenerate(t *testing.T) {
+	if runtime.GOOS == "windows" {
+		t.Skip("protobuf regeneration is not supported on Windows")
+	}
 	err := Exec("./gen.sh")
 	require.NoError(t, err, "Got error while regenerating protos: %v\n", err)
 

value_test.go

@@ -24,6 +24,7 @@ import (
 	"math/rand"
 	"os"
 	"reflect"
+	"runtime"
 	"sync"
 	"testing"
 	"time"
@@ -726,8 +727,12 @@ func TestReadOnlyOpenWithPartialAppendToWAL(t *testing.T) {
 	opts.ReadOnly = true
 	// Badger should fail a read-only open with values to replay
 	_, err = Open(opts)
-	require.Error(t, err)
-	require.Regexp(t, "Log truncate required", err.Error())
+	if runtime.GOOS == "windows" {
+		require.Equal(t, err, ErrWindowsNotSupported)
+	} else {
+		require.Error(t, err)
+		require.Regexp(t, "Log truncate required", err.Error())
+	}
 }
 
 func TestValueLogTrigger(t *testing.T) {
@@ -796,6 +801,10 @@ func createMemFile(t *testing.T, entries []*Entry) ([]byte, uint32) {
 
 // This test creates two mem files and corrupts the last bit of the first file.
 func TestPenultimateMemCorruption(t *testing.T) {
+	if runtime.GOOS == "windows" {
+		t.Skip("skipping corruption tests on Windows since it does not allow removal of mmaped files")
+	}
+
 	dir, err := ioutil.TempDir("", "badger-test")
 	require.NoError(t, err)
 	defer removeDir(dir)