Fix VerifyValueChecksum checks #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuesmiddt
requested review from
ashish-goswami,
jarifibrahim,
manishrjain and
a team
as code owners
jarifibrahim
approved these changes
Dec 1, 2019
There was a problem hiding this comment.
Thank you for fixing this @tuesmiddt. The PR looks good to me 👍 💯
jarifibrahim
pushed a commit
that referenced
this pull request
Dec 6, 2019
PR #1138 fixed the checksum issue but it was missing a test. This PR adds a test for it.
jarifibrahim
pushed a commit
that referenced
this pull request
Mar 12, 2020
jarifibrahim
pushed a commit
that referenced
this pull request
Mar 12, 2020
manishrjain
pushed a commit
to outcaste-io/outserv
that referenced
this pull request
Jul 6, 2022
PR dgraph-io/badger#1138 fixed the checksum issue but it was missing a test. This PR adds a test for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1127
Issue was that crc32 value read from log was included when recomputing hash value for verification.
This change is