Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate proto files #1092

Merged
merged 1 commit into from
Oct 21, 2019
Merged

Regenerate proto files #1092

merged 1 commit into from
Oct 21, 2019

Conversation

jarifibrahim
Copy link
Contributor

@jarifibrahim jarifibrahim commented Oct 21, 2019

The proto files in the current master are not compatible with the ones in dgraph. See build for PR hypermodeinc/dgraph#4200

	[Step 3/5] # github.com/dgraph-io/dgraph/protos/pb
[11:02:11]	[Step 3/5] ../protos/pb/pb.pb.go:7146:29: m.Kv[iNdEx].MarshalToSizedBuffer undefined (type *pb.KV has no field or method MarshalToSizedBuffer)
[11:02:11]	[Step 3/5] ../protos/pb/pb.pb.go:7209:29: m.Kv[iNdEx].MarshalToSizedBuffer undefined (type *pb.KV has no field or method MarshalToSizedBuffer)
[11:02:40]	[Step 3/5] Makefile:66: recipe for target 'install' failed
[11:02:40]	[Step 3/5] make[1]: *** [install] Error 2
[11:02:40]	[Step 3/5] make[1]: Leaving directory '/home/pawan0201/go/src/github.com/dgraph-io/dgraph/dgraph'
[11:02:40]	[Step 3/5] make: *** [install] Error 2
[11:02:40]	[Step 3/5] Makefile:43: recipe for target 'install' failed
[11:02:40]	[Step 3/5] Process exited with code 2

https://teamcity.dgraph.io/viewLog.html?buildId=29232&buildTypeId=Dgraph_Blockade&tab=buildLog

This PR the proto files in badger. I've run ./gen.sh script to regenerate these.


This change is Reviewable

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ A review job has been created and sent to the PullRequest network.


@jarifibrahim you can click here to see the review status or cancel the code review job.

@coveralls
Copy link

coveralls commented Oct 21, 2019

Coverage Status

Coverage decreased (-0.03%) to 77.449% when pulling 4037482 on ibrahim/proto-update into b9056f1 on master.

@jarifibrahim jarifibrahim merged commit be6402f into master Oct 21, 2019
@jarifibrahim jarifibrahim deleted the ibrahim/proto-update branch October 21, 2019 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants