-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adds CSS support to
prerender_component_publish_files()
.
Refs #39. This mostly comes down to just including styles in the output `filegroup()`, but it also required some updates to the PostCSS import plugin configuration. The original implementation did not correctly handle loading CSS files from other workspaces because we previously assumed that the `execroot/` directory would contain all the workspaces for the action, but it actually only contains the primary workspace the action is running in. External workspaces are actually loaded under `execroot/${primaryWorkspace}/external/${externalWorkspaces}`. To add confusion, `npm` is one workspace, and everything installed via `node_repositories()` goes under there. So instead, I just updated the logic to look in directories directly under `external/npm/`, treating those as external workspaces. That's not entirely accurate, but usable enough for the DX I'm looking for. Again, it's really hard to test the plugin configuration, but I've done so manually for now using [`ref/external`](https://github.com/dgp1130/rules_prerender/tree/ref/external/).
- Loading branch information
Showing
5 changed files
with
57 additions
and
32 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.