Skip to content

Commit

Permalink
Removes import 'jasmine';.
Browse files Browse the repository at this point in the history
This is an issue for the `@aspect_rules_js` version of `jasmine_node_test()` and wasn't load-bearing for `@build_bazel_rules_nodejs` anyways, so the simplest solution is to just delete it.

Generated this commit with a simple find/replace in VSCode, looking for `import 'jasmine';\n\n` and replacing with "". Then did another search for `import 'jasmine';` and fixed a few stragglers which fell through the cracks.
  • Loading branch information
dgp1130 committed Jul 20, 2022
1 parent a4a723a commit fed5ebc
Show file tree
Hide file tree
Showing 59 changed files with 0 additions and 118 deletions.
2 changes: 0 additions & 2 deletions .vscode/jasmine.code-snippets
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@
"scope": "javascript,typescript",
"prefix": "jas",
"body": [
"import 'jasmine';",
"",
"describe('${1:file_under_test}', () => {",
" describe('${2:functionUnderTest}()', () => {",
" it('${3:does a thing}', ${4:async }() => {",
Expand Down
2 changes: 0 additions & 2 deletions common/binary_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { main as mainReal } from './binary';

// Wrap `main`'s type to return its `Promise` to easily `await` it.
Expand Down
2 changes: 0 additions & 2 deletions common/collections_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { unique } from './collections';

describe('collections', () => {
Expand Down
2 changes: 0 additions & 2 deletions common/formatters_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { mdSpacing } from './formatters';

describe('formatters', () => {
Expand Down
2 changes: 0 additions & 2 deletions common/http_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import nodeHttp from 'http';
import { URL } from 'url';
import * as http from './http';
Expand Down
2 changes: 0 additions & 2 deletions common/models/prerender_annotation_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { PrerenderAnnotation, createAnnotation, parseAnnotation, ScriptAnnotation, annotationsEqual, StyleAnnotation } from './prerender_annotation';

describe('prerender_annotation', () => {
Expand Down
2 changes: 0 additions & 2 deletions common/models/prerender_metadata_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { PrerenderMetadata, ScriptMetadata } from './prerender_metadata';

describe('prerender_metadata', () => {
Expand Down
2 changes: 0 additions & 2 deletions common/models/prerender_resource_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { PrerenderResource } from './prerender_resource';

describe('PrerenderResource', () => {
Expand Down
2 changes: 0 additions & 2 deletions common/models/url_path_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { UrlPath } from './url_path';

describe('UrlPath', () => {
Expand Down
2 changes: 0 additions & 2 deletions common/prerender_annotation_walker_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { HTMLElement, parse } from 'node-html-parser';
import { createAnnotation } from './models/prerender_annotation';
import { walkAllAnnotations } from './prerender_annotation_walker';
Expand Down
2 changes: 0 additions & 2 deletions common/testing/binary_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { promises as fs } from 'fs';
import { execBinary } from './binary';
import { useTempDir } from './temp_dir';
Expand Down
2 changes: 0 additions & 2 deletions common/testing/devserver.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { execFile as execFileCb, ChildProcess, ExecException } from 'child_process';
import { StatusCodes } from 'http-status-codes';
import killTree from 'tree-kill';
Expand Down
2 changes: 0 additions & 2 deletions common/testing/devserver_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { URL } from 'url';
import { StatusCodes } from 'http-status-codes';
import { runfiles } from '@bazel/runfiles';
Expand Down
2 changes: 0 additions & 2 deletions common/testing/effect_fake_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { Effect } from './effects';
import { effectFake } from './effect_fake';

Expand Down
3 changes: 0 additions & 3 deletions common/testing/effect_tester.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { Effect } from './effects';

/**
Expand All @@ -13,7 +11,6 @@ import { Effect } from './effects';
* Example usage:
*
* ```typescript
* import 'jasmine';
* import { Effect, useForEach } from '.../effects';
* import { Foo } from './foo';
*
Expand Down
2 changes: 0 additions & 2 deletions common/testing/effect_tester_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { useForEach } from './effects';
import { effectFake } from './effect_fake';
import { EffectTester } from './effect_tester';
Expand Down
2 changes: 0 additions & 2 deletions common/testing/effects.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@
* creating it or cleaning it up.
*/

import 'jasmine';

// Not `undefined` or `null`.
// eslint-disable-next-line @typescript-eslint/ban-types
type Defined = string | number | boolean | symbol | object;
Expand Down
1 change: 0 additions & 1 deletion common/testing/effects_test.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import 'jasmine';
import { useForAll, useForEach } from './effects';

describe('effects', () => {
Expand Down
2 changes: 0 additions & 2 deletions common/testing/mocks.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
/** @fileoverview Utilities around mocking objects. */

import 'jasmine';

/**
* Returns an object type containing only the publicly available properties of
* the input. This is useful because TypeScript interfaces include private
Expand Down
2 changes: 0 additions & 2 deletions common/testing/mocks_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { unmockedFunc } from './mocks';

describe('mocks', () => {
Expand Down
2 changes: 0 additions & 2 deletions common/testing/temp_dir_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { env } from 'process';
import { useTempDir } from './temp_dir';
import { EffectTester } from './effect_tester';
Expand Down
2 changes: 0 additions & 2 deletions common/testing/test_server_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { TestServer } from './test_server';

describe('test_server', () => {
Expand Down
2 changes: 0 additions & 2 deletions common/testing/webdriver_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { runfiles } from '@bazel/runfiles';
import * as webdriverio from 'webdriverio';
import { useDevserver } from './devserver';
Expand Down
2 changes: 0 additions & 2 deletions examples/components/test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { runfiles } from '@bazel/runfiles';
import { useDevserver } from '../../common/testing/devserver';
import { useWebDriver, webDriverTestTimeout } from '../../common/testing/webdriver';
Expand Down
2 changes: 0 additions & 2 deletions examples/custom_bundling/test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { runfiles } from '@bazel/runfiles';
import { useDevserver } from '../../common/testing/devserver';
import { useWebDriver, webDriverTestTimeout } from '../../common/testing/webdriver';
Expand Down
2 changes: 0 additions & 2 deletions examples/data/test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { runfiles } from '@bazel/runfiles';
import { useDevserver } from '../../common/testing/devserver';
import { useWebDriver, webDriverTestTimeout } from '../../common/testing/webdriver';
Expand Down
2 changes: 0 additions & 2 deletions examples/declarative_shadow_dom/test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { runfiles } from '@bazel/runfiles';
import { useDevserver } from '../../common/testing/devserver';
import { getColor, useWebDriver, webDriverTestTimeout } from '../../common/testing/webdriver';
Expand Down
2 changes: 0 additions & 2 deletions examples/javascript/test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { runfiles } from '@bazel/runfiles';
import { useDevserver } from '../../common/testing/devserver';
import { useWebDriver, webDriverTestTimeout } from '../../common/testing/webdriver';
Expand Down
2 changes: 0 additions & 2 deletions examples/minimal/test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { runfiles } from '@bazel/runfiles';
import { useDevserver } from '../../common/testing/devserver';
import { useWebDriver, webDriverTestTimeout } from '../../common/testing/webdriver';
Expand Down
2 changes: 0 additions & 2 deletions examples/multi_page/test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { runfiles } from '@bazel/runfiles';
import { useDevserver } from '../../common/testing/devserver';
import { getColor, useWebDriver, webDriverTestTimeout } from '../../common/testing/webdriver';
Expand Down
2 changes: 0 additions & 2 deletions examples/prerender_resources/generator_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { promises as fs } from 'fs';
import { runfiles } from '@bazel/runfiles';

Expand Down
2 changes: 0 additions & 2 deletions examples/resources/test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { runfiles } from '@bazel/runfiles';
import { useDevserver } from '../../common/testing/devserver';
import { useWebDriver, webDriverTestTimeout } from '../../common/testing/webdriver';
Expand Down
2 changes: 0 additions & 2 deletions examples/scripts/test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { runfiles } from '@bazel/runfiles';
import { useDevserver } from '../../common/testing/devserver';
import { useWebDriver, webDriverTestTimeout } from '../../common/testing/webdriver';
Expand Down
2 changes: 0 additions & 2 deletions examples/site/blog/blog_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import parse from 'node-html-parser';
import renderBlog from './blog';

Expand Down
2 changes: 0 additions & 2 deletions examples/site/components/base/base_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { HTMLElement, parse, NodeType } from 'node-html-parser';
import { baseLayout } from './base';

Expand Down
2 changes: 0 additions & 2 deletions examples/site/components/counter/counter_prerender_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { parse } from 'node-html-parser';
import { renderCounter } from './counter_prerender';

Expand Down
2 changes: 0 additions & 2 deletions examples/site/components/counter/counter_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { runfiles } from '@bazel/runfiles';
import { useDevserver } from '../../../../common/testing/devserver';
import { useWebDriver, webDriverTestTimeout } from '../../../../common/testing/webdriver';
Expand Down
2 changes: 0 additions & 2 deletions examples/site/components/footer/footer_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { parse } from 'node-html-parser';
import { renderFooter } from './footer';

Expand Down
2 changes: 0 additions & 2 deletions examples/site/components/header/header_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import parse from 'node-html-parser';
import { renderHeader } from './header';

Expand Down
2 changes: 0 additions & 2 deletions examples/site/home/home_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { runfiles } from '@bazel/runfiles';
import { useDevserver } from '../../../common/testing/devserver';
import { useWebDriver, webDriverTestTimeout } from '../../../common/testing/webdriver';
Expand Down
2 changes: 0 additions & 2 deletions examples/styles/test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { runfiles } from '@bazel/runfiles';
import { useDevserver } from '../../common/testing/devserver';
import { getColor, useWebDriver } from '../../common/testing/webdriver';
Expand Down
2 changes: 0 additions & 2 deletions examples/tsjs/test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { runfiles } from '@bazel/runfiles';
import { useDevserver } from '../../common/testing/devserver';
import { useWebDriver, webDriverTestTimeout } from '../../common/testing/webdriver';
Expand Down
2 changes: 0 additions & 2 deletions packages/annotation_extractor/annotation_extractor_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { promises as fs } from 'fs';
import { runfiles } from '@bazel/runfiles';
import { mockPrerenderMetadata, mockScriptMetadata } from '../../common/models/prerender_metadata_mock';
Expand Down
2 changes: 0 additions & 2 deletions packages/annotation_extractor/extractor_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { extract } from './extractor';
import { createAnnotation } from '../../common/models/prerender_annotation';

Expand Down
2 changes: 0 additions & 2 deletions packages/annotation_extractor/metadata_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { mockScriptAnnotation, mockStyleAnnotation } from '../../common/models/prerender_annotation_mock';
import { mockPrerenderMetadata, mockScriptMetadata } from '../../common/models/prerender_metadata_mock';
import { assembleMetadata } from './metadata';
Expand Down
2 changes: 0 additions & 2 deletions packages/renderer/entry_point_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { PrerenderResource } from '../../common/models/prerender_resource';
import { invoke } from './entry_point';
import * as importLib from './dynamic_import';
Expand Down
2 changes: 0 additions & 2 deletions packages/renderer/renderer_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { promises as fs } from 'fs';
import { runfiles } from '@bazel/runfiles';
import { execBinary, ProcessResult } from '../../common/testing/binary';
Expand Down
2 changes: 0 additions & 2 deletions packages/resource_injector/injector_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import * as fs from '../../common/fs';
import { createAnnotation } from '../../common/models/prerender_annotation';
import { InjectorConfig } from './config';
Expand Down
2 changes: 0 additions & 2 deletions packages/resource_injector/resource_injector_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { promises as fs } from 'fs';
import { runfiles } from '@bazel/runfiles';
import { InjectorConfig } from './config';
Expand Down
2 changes: 0 additions & 2 deletions packages/resource_packager/package_loader_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { loadPackage } from './package_loader';
import { useTempDir } from '../../common/testing/temp_dir';
import { promises as fs } from 'fs';
Expand Down
2 changes: 0 additions & 2 deletions packages/resource_packager/packager_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import * as fs from '../../common/fs';
import { pack } from './packager';
import { ResourceMap } from './resource_map';
Expand Down
2 changes: 0 additions & 2 deletions packages/resource_packager/resource_map_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { ResourceMap } from './resource_map';
import { mockFileRef } from './resource_map_mock';

Expand Down
2 changes: 0 additions & 2 deletions packages/resource_packager/resource_packager_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { promises as fs } from 'fs';
import { runfiles } from '@bazel/runfiles';
import { useTempDir } from '../../common/testing/temp_dir';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { createAnnotation } from '../../../common/models/prerender_annotation';
import { polyfillDeclarativeShadowDom } from './declarative_shadow_dom';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { runfiles } from '@bazel/runfiles';
import { promises as fs } from 'fs';

Expand Down
2 changes: 0 additions & 2 deletions packages/rules_prerender/scripts_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { createAnnotation } from '../../common/models/prerender_annotation';
import { includeScript } from './scripts';

Expand Down
2 changes: 0 additions & 2 deletions packages/rules_prerender/styles_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import * as inlineStyleMap from './inline_style_map';
import { createAnnotation } from '../../common/models/prerender_annotation';
import { inlineStyle, InlineStyleNotFoundError } from './styles';
Expand Down
2 changes: 0 additions & 2 deletions packages/script_entry_generator/generator_test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { mockPrerenderMetadata } from '../../common/models/prerender_metadata_mock';
import { generateEntryPoint } from './generator';

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import 'jasmine';

import { promises as fs } from 'fs';
import { runfiles } from '@bazel/runfiles';
import { mockPrerenderMetadata, mockScriptMetadata } from '../../common/models/prerender_metadata_mock';
Expand Down

0 comments on commit fed5ebc

Please sign in to comment.