Skip to content

Commit

Permalink
Removes @aspect_rules_rollup dependency.
Browse files Browse the repository at this point in the history
Refs #56.

In #26 we updated the Rollup integration to use a custom rule which directly invokes the `rollup` binary, so there's no need for `@aspect_rules_rollup` anymore.
  • Loading branch information
dgp1130 committed Feb 27, 2023
1 parent 85d3cf7 commit f32b3d5
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 30 deletions.
14 changes: 0 additions & 14 deletions WORKSPACE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -77,20 +77,6 @@ jasmine_repositories(name = "jasmine")
load("@jasmine//:npm_repositories.bzl", jasmine_npm_repositories = "npm_repositories")
jasmine_npm_repositories()

# Install `@aspect_rules_rollup`.
http_archive(
name = "aspect_rules_rollup",
sha256 = "2a0c863fa4ca35cc2d49b63637792d38262f71fc0590c76b7946838614c94fda",
strip_prefix = "rules_rollup-0.13.0",
url = "https://github.com/aspect-build/rules_rollup/archive/refs/tags/v0.13.0.tar.gz",
)
load("@aspect_rules_rollup//rollup:dependencies.bzl", "rules_rollup_dependencies")
rules_rollup_dependencies()
load("@aspect_rules_rollup//rollup:repositories.bzl", "rollup_repositories")
rollup_repositories(name = "rollup")
load("@rollup//:npm_repositories.bzl", rollup_npm_repositories = "npm_repositories")
rollup_npm_repositories()

# Load bazel_skylib.
http_archive(
name = "bazel_skylib",
Expand Down
8 changes: 0 additions & 8 deletions dependencies.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,6 @@ def rules_prerender_dependencies():
url = "https://github.com/aspect-build/rules_js/releases/download/v1.19.0/rules_js-v1.19.0.tar.gz",
)

maybe(
http_archive,
name = "aspect_rules_rollup",
sha256 = "2a0c863fa4ca35cc2d49b63637792d38262f71fc0590c76b7946838614c94fda",
strip_prefix = "rules_rollup-0.13.0",
url = "https://github.com/aspect-build/rules_rollup/archive/refs/tags/v0.13.0.tar.gz",
)

maybe(
http_archive,
name = "aspect_rules_ts",
Expand Down
2 changes: 0 additions & 2 deletions npm_repositories.bzl
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
load("@jasmine//:npm_repositories.bzl", jasmine_npm_repositories = "npm_repositories")
load("@rollup//:npm_repositories.bzl", rollup_npm_repositories = "npm_repositories")
load("@rules_prerender_npm//:repositories.bzl", js_npm_repositories = "npm_repositories")

def npm_repositories():
js_npm_repositories()
rollup_npm_repositories()
jasmine_npm_repositories()
6 changes: 0 additions & 6 deletions repositories.bzl
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
load("@aspect_rules_jasmine//jasmine:repositories.bzl", "jasmine_repositories")
load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")
load("@aspect_rules_js//npm:npm_import.bzl", "npm_translate_lock")
load("@aspect_rules_rollup//rollup:dependencies.bzl", "rules_rollup_dependencies")
load("@aspect_rules_rollup//rollup:repositories.bzl", "rollup_repositories")
load("@aspect_rules_ts//ts:repositories.bzl", "rules_ts_dependencies")

def rules_prerender_repositories():
Expand All @@ -15,9 +13,5 @@ def rules_prerender_repositories():

rules_ts_dependencies(ts_version_from = Label("//:package.json"))

if "rollup" not in native.existing_rules():
rules_rollup_dependencies()
rollup_repositories(name = "rollup")

if "jasmine" not in native.existing_rules():
jasmine_repositories(name = "jasmine")

0 comments on commit f32b3d5

Please sign in to comment.