Skip to content

Commit

Permalink
Makes //:node_modules/@rules_prerender/declarative_shadow_dom private.
Browse files Browse the repository at this point in the history
Refs #71.

I accidentally used this target today when I actually wanted `//:prerender_components/@rules_prerender/declarative_shadow_dom`. There is not much use for the Node module and using it directly violates the expectation that all the various "slices" of the component stay together in a cohesive way. Limiting visibility makes it easier to catch this mistake in the future.
  • Loading branch information
dgp1130 committed Mar 13, 2023
1 parent 46f5930 commit e0bc134
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@ types_only(
npm_link_package(
name = "node_modules/@rules_prerender/declarative_shadow_dom",
src = "//packages/declarative_shadow_dom:pkg",
visibility = ["//:__subpackages__"],
# Should use `//:prerender_components/@rules_prerender/declarative_shadow_dom`.
visibility = ["//visibility:private"],
)
link_prerender_component(
name = "prerender_components/@rules_prerender/declarative_shadow_dom",
Expand Down

0 comments on commit e0bc134

Please sign in to comment.