Skip to content

Commit

Permalink
Pins Jasmine version.
Browse files Browse the repository at this point in the history
Refs #33.

The actual version of Jasmine used comes from `jasmine_repositories()`, not `package.json`. `@aspect_rules_jasmine` runs its own `npm install` under the hood to get the specific version of Jasmine. This commit drops the `jasmine` dependency in `package.json`, which is actually unused. It also bumps the `@types/jasmine` dependency to the current latest. Unfortunately `jasmine` and `@types/jasmine` don't directly correlate, so we can't forcibly align the versions there.
  • Loading branch information
dgp1130 committed Mar 4, 2023
1 parent 3bb306a commit 9c4f707
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 21 deletions.
5 changes: 4 additions & 1 deletion WORKSPACE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,10 @@ load("@aspect_rules_jasmine//jasmine:dependencies.bzl", "rules_jasmine_dependenc
rules_jasmine_dependencies()

load("@aspect_rules_jasmine//jasmine:repositories.bzl", "jasmine_repositories")
jasmine_repositories(name = "jasmine")
jasmine_repositories(
name = "jasmine",
jasmine_version = "v4.3.0",
)

load("@jasmine//:npm_repositories.bzl", jasmine_npm_repositories = "npm_repositories")
jasmine_npm_repositories()
Expand Down
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,14 @@
"@bazel/bazelisk": "latest",
"@bazel/buildifier": "latest",
"@bazel/ibazel": "latest",
"@types/jasmine": "^3.6.2",
"@types/jasmine": "^4.3.1",
"@types/node": "^14.14.13",
"@types/yargs": "^15.0.11",
"@typescript-eslint/eslint-plugin": "^4.29.3",
"@typescript-eslint/parser": "^4.29.3",
"eslint": "^7.32.0",
"http-status-codes": "^2.1.4",
"husky": "^7.0.2",
"jasmine": "^4.3.0",
"tree-kill": "^1.2.2",
"typescript": "4.9.5",
"webdriverio": "^7.20.9"
Expand Down
22 changes: 4 additions & 18 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 9c4f707

Please sign in to comment.