Updates nodejs_register_toolchains() calls to use the Node version …

…from `.nvmrc`. This reduces duplication in the version numbers and consolidates on a single source of truth. I also added a `.nvmrc` to `examples/external/` as a symlink to the root `.nvmrc`.
dgp1130 · Feb 18, 2023 · 66988ba · 66988ba
1 parent 92ecea5
commit 66988ba
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/WORKSPACE.bazel b/WORKSPACE.bazel
@@ -31,7 +31,7 @@ rules_js_dependencies()
 load("@rules_nodejs//nodejs:repositories.bzl", "nodejs_register_toolchains")
 nodejs_register_toolchains(
     name = "nodejs", # Default name used by most tools.
-    node_version = "16.10.0",
+    use_nvmrc = "//:.nvmrc",
 )
 
 # Install NPM packages from the lockfile.

diff --git a/examples/external/.nvmrc b/examples/external/.nvmrc
@@ -0,0 +1 @@
+../../.nvmrc
diff --git a/examples/external/WORKSPACE.bazel b/examples/external/WORKSPACE.bazel
@@ -28,7 +28,7 @@ rules_js_dependencies()
 load("@rules_nodejs//nodejs:repositories.bzl", "nodejs_register_toolchains")
 nodejs_register_toolchains(
     name = "nodejs",
-    node_version = "16.10.0",
+    use_nvmrc = "//:.nvmrc",
 )
 
 load("@aspect_rules_js//npm:npm_import.bzl", "npm_translate_lock")