Skip to content

Commit

Permalink
Deletes publish_files().
Browse files Browse the repository at this point in the history
Refs #63.

`publish_files()` was only ever needed for the `@build_bazel_rules_nodejs` version of publishing to NPM, where the whole workspace was included in the NPM package. Now workspace dependencies and NPM dependencies are two different things, and `npm_package()` already constructs everything we need for the NPM package. We no longer have any need for `publish_files()`.
  • Loading branch information
dgp1130 committed Feb 18, 2023
1 parent 00e75cf commit 1101e37
Show file tree
Hide file tree
Showing 9 changed files with 0 additions and 111 deletions.
12 changes: 0 additions & 12 deletions BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
load("@bazel_skylib//lib:dicts.bzl", "dicts")
load("@bazel_skylib//rules:build_test.bzl", "build_test")
load("@npm_rules_js//:defs.bzl", "npm_link_all_packages")
load("//tools:publish.bzl", "publish_files")
load("//tools/publish:npm_publish.bzl", "npm_publish")
load("//tools/stamping:stamp_package.bzl", "stamp_package")
load("//tools:typescript.bzl", "types_only")
Expand Down Expand Up @@ -111,14 +110,3 @@ prerender_component_publish_files(
name = "declarative_shadow_dom_publish_files",
dep = ":declarative_shadow_dom",
)

publish_files(
name = "publish_files",
files = [
".npmrc",
"README.md",
"index.bzl",
"package.json",
":declarative_shadow_dom_publish_files",
],
)
7 changes: 0 additions & 7 deletions common/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,16 +1,9 @@
load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
load("//tools:jasmine.bzl", "jasmine_node_test")
load("//tools:publish.bzl", "publish_files")
load("//tools:typescript.bzl", "ts_project")
load(":label_test.bzl", "label_test_suite")
load(":paths_test.bzl", "paths_test_suite")

publish_files(
name = "publish_files",
files = glob(["**/*.bzl"]),
visibility = ["//:__pkg__"],
)

ts_project(
name = "binary",
srcs = ["binary.ts"],
Expand Down
7 changes: 0 additions & 7 deletions packages/renderer/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,15 +1,8 @@
load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
load("//tools:jasmine.bzl", "jasmine_node_test")
load("//tools:publish.bzl", "publish_files")
load("//tools:typescript.bzl", "ts_project")
load(":build_vars.bzl", "RENDERER_RUNTIME_DEPS")

publish_files(
name = "publish_files",
files = glob(["**/*.bzl"]),
visibility = ["//:__pkg__"],
)

ts_project(
name = "renderer",
srcs = ["renderer.ts"],
Expand Down
11 changes: 0 additions & 11 deletions packages/rules_prerender/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
load("//:index.bzl", "prerender_component")
load("//tools:jasmine.bzl", "jasmine_node_test")
load("//tools:publish.bzl", "publish_files")
load("//tools:typescript.bzl", "ts_project")

exports_files(
Expand Down Expand Up @@ -29,16 +28,6 @@ prerender_component(
deps = ["//packages/rules_prerender/declarative_shadow_dom"],
)

publish_files(
name = "publish_files",
files = glob(["**/*.bzl"]) + [
"rollup-default.config.js",
"//packages/rules_prerender/css:publish_files",
"//packages/rules_prerender/declarative_shadow_dom:publish_files",
],
visibility = ["//:__pkg__"],
)

bzl_library(
name = "script_entry_point",
srcs = ["script_entry_point.bzl"],
Expand Down
7 changes: 0 additions & 7 deletions packages/rules_prerender/css/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,11 +1,4 @@
load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
load("//tools:publish.bzl", "publish_files")

publish_files(
name = "publish_files",
files = glob(["**/*.bzl"]),
visibility = ["//packages/rules_prerender:__pkg__"],
)

bzl_library(
name = "css_binaries",
Expand Down
7 changes: 0 additions & 7 deletions packages/rules_prerender/declarative_shadow_dom/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,10 @@ load(
"prerender_component_publish_files",
)
load("//tools:jasmine.bzl", "jasmine_node_test")
load("//tools:publish.bzl", "publish_files")
load("//tools:typescript.bzl", "ts_project")
load("//tools/publish:npm_publish.bzl", "npm_publish")
load("//tools/stamping:stamp_package.bzl", "stamp_package")

publish_files(
name = "publish_files",
files = [":declarative_shadow_dom_publish_files"],
visibility = ["//packages/rules_prerender:__pkg__"],
)

prerender_component_publish_files(
name = "declarative_shadow_dom_publish_files",
dep = ":declarative_shadow_dom",
Expand Down
6 changes: 0 additions & 6 deletions tools/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,3 @@ bzl_library(
srcs = ["jasmine_web_test_suite.bzl"],
deps = [":jasmine_node_test"],
)

bzl_library(
name = "publish",
srcs = ["publish.bzl"],
visibility = ["//visibility:public"],
)
7 changes: 0 additions & 7 deletions tools/internal/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,8 @@ referenced when needed at build time in this repository. A sibling
in the user's repository.
"""

load("//tools:publish.bzl", "publish_files")

package(default_visibility = ["//visibility:public"])

publish_files(
name = "publish_files",
visibility = ["//:__pkg__"],
)

alias(
name = "annotation_extractor",
actual = "//packages/annotation_extractor",
Expand Down
47 changes: 0 additions & 47 deletions tools/publish.bzl

This file was deleted.

0 comments on commit 1101e37

Please sign in to comment.