Skip to content
This repository has been archived by the owner on Jun 21, 2020. It is now read-only.

Commit

Permalink
Corrects shebang of bxpb-protoc-plugin.
Browse files Browse the repository at this point in the history
Refs #1.

CI appears to be failing, due to a missing `packages/bxpb-protoc-plugin/bin/bxpb-protoc-plugin` file. This is weird to me as the file is directly checked in to source.

https://github.com/dgp1130/bxpb/runs/702931728

The symlink appears to work as expected after passing through a wrapper shell script from lerna/lerna#2059, and that script works correctly when used locally.

While doing some investigation, I noticed an NPM best practice of using `#!/usr/bin/env node` for the shebang line. I'm hoping GitHub actions just has the Node binary in a different location and printed a very bad error message. Only one way to find out!
  • Loading branch information
dgp1130 committed May 24, 2020
1 parent d2519b5 commit 01d4dbe
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/bxpb-protoc-plugin/src/bxpb-protoc-plugin.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/usr/bin/node
#!/usr/bin/env node

import { execute } from './plugin';

Expand Down

0 comments on commit 01d4dbe

Please sign in to comment.