-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Updates demo components to use
defineBaseComponent
where appropriate.
Any components which don't use signals don't need `defineSignalComponent`. I was a little torn on this just because I want developers to think of `defineSignalComponent` as the "default" option and would rather not draw too much attention to `defineBaseComponent`. That said, these examples should be as minimal as possible, so eliminating signals from their dependencies seems like a good move and it doesn't really make things less clear. The main challenge is that someone might copy an example with `defineBaseComponent` and then copy a `.effect` call or a `live` binding from another component and then be confused when it doesn't work. That's probably more of a documentation issue than one with the examples, so I'm inclined to used `defineBaseComponent` where possible for now.
- Loading branch information
Showing
6 changed files
with
13 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters