convert bidders: improveddigital

dgirardi · May 20, 2022 · 1105c2a · 1105c2a
1 parent 535ff28
commit 1105c2a
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 22 deletions.
diff --git a/modules/id5IdSystem.js b/modules/id5IdSystem.js
@@ -122,7 +122,7 @@ export const id5IdSubmodule = {
       'gdpr': hasGdpr,
       'nbPage': incrementNb(config.params.partner),
       'o': 'pbjs',
-      'rf': referer.referer,
+      'rf': referer.topmostLocation,
       'top': referer.reachedTop ? 1 : 0,
       'u': referer.stack[0] || window.location.href,
       'v': '$prebid.version$'

diff --git a/modules/impactifyBidAdapter.js b/modules/impactifyBidAdapter.js
@@ -65,7 +65,7 @@ const createOpenRtbRequest = (validBidRequests, bidderRequest) => {
     dnt: (navigator.doNotTrack == 'yes' || navigator.doNotTrack == '1' || navigator.msDoNotTrack == '1') ? 1 : 0,
     language: ((navigator.language || navigator.userLanguage || '').split('-'))[0] || 'en',
   };
-  request.site = {page: bidderRequest.refererInfo.referer};
+  request.site = {page: bidderRequest.refererInfo.page};
 
   // Handle privacy settings for GDPR/CCPA/COPPA
   let gdprApplies = 0;

diff --git a/modules/improvedigitalBidAdapter.js b/modules/improvedigitalBidAdapter.js
@@ -434,10 +434,10 @@ const ID_REQUEST = {
       request.app = app;
     } else {
       const site = {};
-      const url = config.getConfig('pageUrl') || deepAccess(bidderRequest, 'refererInfo.referer');
+      const url = deepAccess(bidderRequest, 'refererInfo.page');
       if (url) {
         site.page = url;
-        site.domain = parseUrl(url).hostname;
+        site.domain = bidderRequest.refererInfo.domain
       }
       const configSiteSettings = config.getConfig('site') || {};
       const fpdSiteSettings = deepAccess(bidderRequest, 'ortb2.site') || {};

diff --git a/test/spec/modules/improvedigitalBidAdapter_spec.js b/test/spec/modules/improvedigitalBidAdapter_spec.js
@@ -118,7 +118,8 @@ describe('Improve Digital Adapter Tests', function () {
   const bidderRequestReferrer = {
     bids: [simpleBidRequest],
     refererInfo: {
-      referer: 'https://blah.com/test.html',
+      page: 'https://blah.com/test.html',
+      domain: 'blah.com'
     },
   };
 
@@ -668,23 +669,6 @@ describe('Improve Digital Adapter Tests', function () {
       getConfigStub.restore();
     });
 
-    it('should set pageUrl as site param', function () {
-      let getConfigStub = sinon.stub(config, 'getConfig');
-      getConfigStub.withArgs('pageUrl').returns('https://improvidigital.com/test-page');
-      let request = spec.buildRequests([simpleBidRequest], bidderRequestReferrer)[0];
-      let payload = JSON.parse(request.data);
-      expect(payload.site.page).does.exist.and.equal('https://improvidigital.com/test-page');
-      expect(payload.site.domain).does.exist.and.equal('improvidigital.com');
-      getConfigStub.reset();
-
-      getConfigStub.withArgs('pageUrl').returns(undefined);
-      request = spec.buildRequests([simpleBidRequest], bidderRequestReferrer)[0];
-      payload = JSON.parse(request.data);
-      expect(payload.site.page).does.exist.and.equal('https://blah.com/test.html');
-      expect(payload.site.domain).does.exist.and.equal('blah.com');
-      getConfigStub.restore();
-    });
-
     it('should set site when app not available', function () {
       const getConfigStub = sinon.stub(config, 'getConfig');
       getConfigStub.withArgs('app').returns(undefined);