Fixed conditional logic in Stitched Requirement check. MP test comple…

…ted successfully.

Added Bandage Reopening Chance Modifier

Added Wound Reopen Chance Addon Setting

Fixed dumb error in localization setup

Credit!

Resolved issue with Addon Settings definition & removed testing values.

PR Feedback #1

- Removed unnecessary whitespace on LN 46
- Call global var directly at LN 87
- Updated Wound Reopen Chance localized name & description

PR Feedback #2

- Increased reopen coefficient upper limit from 2 to 5.

Changed author credit to reflect GitHub email.

Added option to restrict PAK when patient has untreated fractures.

Changed formatting and global variable.

Credit to @mharis001.

Apply suggestions from code review

Corrected issue with checking array equality.

Update fnc_isInStableCondition.sqf

Merge pull request #1 from dgibso29/pr/7684

Corrected issue with checking array equality.

Updated to directly check for open wounds

Updated default minimum blood value to use a PAK per mharis001's comment

Properly set up minimum blood required to use PAK as a percentage slider

Forgot to include the REQUIRED BOOL to make the MinBloodPak slider a percentage...

Resolved scope issue with checking for unbandaged wounds

Why exitWith when you can break

Update fnc_isInStableCondition.sqf

Update fnc_isInStableCondition.sqf

Merge branch 'master' into pr/7684

Revert "Merge branch 'master' into pr/7684"

This reverts commit 0f46553, reversing
changes made to b30de99.

Update fnc_isInStableCondition.sqf

Update fnc_isInStableCondition.sqf

Update fnc_isInStableCondition.sqf

Updated Required Wound State to PAK to current standard -- Bandaged wounds.

Update fnc_isInStableCondition.sqf

Update fnc_isInStableCondition.sqf

Update fnc_isInStableCondition.sqf

Updated Required Wound State to PAK to current standard -- Bandaged wounds.

Fixed conditional logic in Stitched Requirement check. MP test completed successfully.

Co-Authored-By: mharis001 <[email protected]>

addons/medical_status/functions/fnc_isInStableCondition.sqf

@@ -27,13 +27,12 @@ private _requiredBloodVolume = DEFAULT_BLOOD_VOLUME * (EGVAR(medical_treatment,m
 if (GET_BLOOD_VOLUME(_unit) < _requiredBloodVolume) exitWith {false};
 
 if (EGVAR(medical_treatment,allowPainPAK) == 0 && { IS_IN_PAIN(_unit) }) exitWith {false};
-if (EGVAR(medical_treatment,allowFracturesPAK) == 0 && { (GET_FRACTURES(_unit) isNotEqualTo []) }) exitWith {false};
+if (EGVAR(medical_treatment,allowFracturesPAK) == 0 && { GET_FRACTURES(_unit) isNotEqualTo [] }) exitWith {false};
 
-// Bangaded wounds required.
-if (EGVAR(medical_treatment,requiredWoundStatePAK) == 1) && {(GET_OPEN_WOUNDS(_unit) findIf {_x select 2 > 0}) != -1} exitWith {false};
+// Bangaded wounds required. This means there can be no open wounds.
+if (EGVAR(medical_treatment,requiredWoundStatePAK) == 1 && { (GET_OPEN_WOUNDS(_unit) findIf {_x select 2 > 0} ) != -1 }) exitWith {false};
 
-// Stitched wounds required.
-//if (EGVAR(medical_treatment,requiredWoundStatePAK) == 2 && { !(count GET_OPEN_WOUNDS(_unit) ==  count GET_STITCHED_WOUNDS(_unit)) }) exitWith {false};
-if (EGVAR(medical_treatment,requiredWoundStatePAK) == 2 && {(GET_BANDAGED_WOUNDS(_unit) findIf {_x select 2 > 0}) != -1 }) exitWith {false};
+// Stitched wounds required. This means there can be no bandaged or open wounds.
+if (EGVAR(medical_treatment,requiredWoundStatePAK) == 2 && { GET_BANDAGED_WOUNDS(_unit) isNotEqualTo [] } || { (GET_OPEN_WOUNDS(_unit) findIf {_x select 2 > 0} ) != -1 }) exitWith {false};
 
 true

addons/medical_treatment/initSettings.sqf

@@ -130,7 +130,7 @@
     "LIST",
     [LSTRING(RequiredWoundStatePAK_DisplayName), LSTRING(RequiredWoundStatePAK_Description)],
     [ELSTRING(medical,Category), LSTRING(SubCategory_Treatment)],
-    [[0, 1, 2], [LSTRING(RequiredWoundStatePAK_Open), LSTRING(Bandaged), LSTRING(RequiredWoundStatePAK_Stitched)], 0],
+    [[0, 1, 2], [LSTRING(RequiredWoundStatePAK_Open), LSTRING(Bandaged), LSTRING(RequiredWoundStatePAK_Stitched)], 1],
     true
 ] call CBA_fnc_addSetting;
 

addons/medical_treatment/stringtable.xml

@@ -102,6 +102,20 @@
             <French>Activé &amp; peuvent se rouvrir</French>
             <Japanese>有効 &amp; 再開放</Japanese>
         </Key>
+        <Key ID="STR_ACE_Medical_Treatment_WoundReopenChance_DisplayName">
+            <English>Wound Reopening Coefficient</English>
+            <French>Coefficient de réouverture des plaies</French>
+            <German>Wundwiederöffnungskoeffizient</German>
+            <Czech>Koeficient opětovného otevření rány</Czech>
+            <Russian>Коэффициент повторного открытия раны</Russian>
+        </Key>
+        <Key ID="STR_ACE_Medical_Treatment_WoundReopenChance_Description">
+            <English>Coefficient for controlling the wound reopening chance. The final reopening chance is determined by multiplying this value with the specific reopening chance for the wound type and bandage used.</English>
+            <French>Coefficient de contrôle des chances de réouverture de la plaie. La chance de réouverture finale est déterminée en multipliant cette valeur par la chance de réouverture spécifique pour le type de plaie et le bandage utilisés.</French>
+            <German>Koeffizient zur Kontrolle der Wundöffnungswahrscheinlichkeit. Die endgültige Wiedereröffnungschance wird bestimmt, indem dieser Wert mit der spezifischen Wiedereröffnungschance für den verwendeten Wundtyp und Verband multipliziert wird.</German>
+            <Czech>Koeficient pro řízení šance na opětovné otevření rány. Konečná šance na opětovné otevření se stanoví vynásobením této hodnoty specifickou šancí na opětovné otevření pro použitý typ rány a obvaz.</Czech>
+            <Russian>Коэффициент контроля вероятности повторного открытия раны. Окончательный шанс повторного открытия определяется путем умножения этого значения на определенный шанс повторного открытия для используемого типа раны и повязки.</Russian>
+        </Key>
         <Key ID="STR_ACE_Medical_Treatment_ClearTraumaAfterBandage_DisplayName">
             <English>Clear Trauma After Bandage</English>
             <Japanese>治療後に外傷を削除</Japanese>