adapter: Fix option parsing #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
name ended up as a unknown option due to not being part of the if/elif block. Signed-off-by: Julian Scheel <[email protected]>
Using shutil.copy is not atomic. The only guaranteed atomic operation is os.rename, which requires source and target to be on the same filesystem. Ensure this by resolving the real file path in case it is symlink and place the tmp file in the same directory. Signed-off-by: Julian Scheel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name ended up as a unknown option due to not being part of the if/elif block.
Signed-off-by: Julian Scheel [email protected]