Fix SWRL parsing #654

vChavezB · 2023-12-11T01:21:32Z

Addes support for correct xslt transformation for TOC and SWRL display. The transformation checks if rdfs:label is defined if not the rules are generically number as they appear in the XML serialization of the ontology.

Fixes #651

  <rdf:Description rdf:about="http://datos.bne.es/vocab/a">
       <rdf:type rdf:resource="http://www.w3.org/2003/11/swrl#Variable"/>
   </rdf:Description>
   <rdf:Description>
       <swrla:isRuleEnabled rdf:datatype="http://www.w3.org/2001/XMLSchema#boolean">true</swrla:isRuleEnabled>
       <rdfs:comment>comment s2</rdfs:comment>
       <rdf:type rdf:resource="http://www.w3.org/2003/11/swrl#Imp"/>
       <swrl:body>
           <rdf:Description>
               <rdf:type rdf:resource="http://www.w3.org/2003/11/swrl#AtomList"/>
               <rdf:first>
                   <rdf:Description>
                       <rdf:type rdf:resource="http://www.w3.org/2003/11/swrl#ClassAtom"/>
                       <swrl:classPredicate rdf:resource="http://datos.bne.es/def/C1001"/>
                       <swrl:argument1 rdf:resource="http://datos.bne.es/vocab/a"/>
                   </rdf:Description>
               </rdf:first>
               <rdf:rest rdf:resource="http://www.w3.org/1999/02/22-rdf-syntax-ns#nil"/>
           </rdf:Description>
       </swrl:body>
       <swrl:head>
           <rdf:Description>
               <rdf:type rdf:resource="http://www.w3.org/2003/11/swrl#AtomList"/>
               <rdf:first>
                   <rdf:Description>
                       <rdf:type rdf:resource="http://www.w3.org/2003/11/swrl#ClassAtom"/>
                       <swrl:classPredicate rdf:resource="http://datos.bne.es/def/C1002"/>
                       <swrl:argument1 rdf:resource="http://datos.bne.es/vocab/a"/>
                   </rdf:Description>
               </rdf:first>
               <rdf:rest rdf:resource="http://www.w3.org/1999/02/22-rdf-syntax-ns#nil"/>
           </rdf:Description>
       </swrl:head>
   </rdf:Description>
   <rdf:Description>
       <swrla:isRuleEnabled rdf:datatype="http://www.w3.org/2001/XMLSchema#boolean">true</swrla:isRuleEnabled>
       <rdfs:comment>comment s1</rdfs:comment>
       <rdfs:label>S1</rdfs:label>
       <rdf:type rdf:resource="http://www.w3.org/2003/11/swrl#Imp"/>
       <swrl:body>
           <rdf:Description>
               <rdf:type rdf:resource="http://www.w3.org/2003/11/swrl#AtomList"/>
               <rdf:first>
                   <rdf:Description>
                       <rdf:type rdf:resource="http://www.w3.org/2003/11/swrl#ClassAtom"/>
                       <swrl:classPredicate rdf:resource="http://datos.bne.es/def/C1001"/>
                       <swrl:argument1 rdf:resource="http://datos.bne.es/vocab/a"/>
                   </rdf:Description>
               </rdf:first>
               <rdf:rest rdf:resource="http://www.w3.org/1999/02/22-rdf-syntax-ns#nil"/>
           </rdf:Description>
       </swrl:body>
       <swrl:head>
           <rdf:Description>
               <rdf:type rdf:resource="http://www.w3.org/2003/11/swrl#AtomList"/>
               <rdf:first>
                   <rdf:Description>
                       <rdf:type rdf:resource="http://www.w3.org/2003/11/swrl#ClassAtom"/>
                       <swrl:classPredicate rdf:resource="http://datos.bne.es/def/C1002"/>
                       <swrl:argument1 rdf:resource="http://datos.bne.es/vocab/a"/>
                   </rdf:Description>
               </rdf:first>
               <rdf:rest rdf:resource="http://www.w3.org/1999/02/22-rdf-syntax-ns#nil"/>
           </rdf:Description>
       </swrl:head>
   </rdf:Description>

and the xslt html transformation

		<div id="swrlrules">
			<h2>SWRL rules</h2>
			<ul class="hlist"></ul>
			<div id="d4e4498" class="entity">
				<h3>Rule #1 
					<span class="backlink">back to 
						<a href="#toc">ToC</a>
					</span>
				</h3>
				<p>
					<strong>Comment: </strong>comment s2
					<br />
					<br />
					<a href="#d4e4288" title="http://datos.bne.es/def/C1001">Work</a>
					<sup title="class" class="type-c">c</sup>(?) -&gt; 
					<a href="#d4e4316" title="http://datos.bne.es/def/C1002">Expression</a>
					<sup title="class" class="type-c">c</sup>(?)
				</p>
			</div>
			<div id="d4e4554" class="entity">
				<h3>Rule #2
					<span class="backlink">back to 
						<a href="#toc">ToC</a>
					</span>
				</h3>
				<p>
					<strong>Comment: </strong>comment s1
					<br />
					<br />
					<a href="#d4e4288" title="http://datos.bne.es/def/C1001">Work</a>
					<sup title="class" class="type-c">c</sup>(?) -&gt; 
					<a href="#d4e4316" title="http://datos.bne.es/def/C1002">Expression</a>
					<sup title="class" class="type-c">c</sup>(?)
				</p>
			</div>
		</div>

dgarijo · 2023-12-11T15:04:26Z

It looks like you are not at fault, I need to review this a little bit in detail @vChavezB. I just need a little time

vChavezB · 2023-12-11T15:04:39Z

Thanks for your quick response btw! I am a little overwhelmed this week, but I'd like to add all these changes before the holidays.

sure no prob!

dgarijo · 2023-12-12T15:48:18Z

Sorry, but the tests don't pass. Are you sure you pass them locally? Which version of Java are you using?

vChavezB · 2023-12-12T17:02:45Z

Let me check why they didnt pass.
Btw i found the bug I think it has to do with h2 tag replacement in the LodeParser

vChavezB · 2023-12-12T17:58:03Z

I think there was a missing import. Also solved the hyperlink of swrl rule sections. I did not use the language properties and at the moment replace it directly see

https://github.com/vChavezB/Widoco/blob/8c9838d12c1b4b418cda4aea6e9d28a27a419d53/src/main/java/widoco/LODEParser.java#L208

vChavezB · 2023-12-16T10:56:57Z

I was experimenting with the project AOWLN, a Protégé plugin to generate images from SWRL rules. I modified it to be used independent of protege to try to integrate it with widoco and named it aowln-sa.

I wanted to integrate it in widoco but due to dependency conflicts (owl-api 4.5.25) and my limted experience with java I am using it separately by generating the images and then modifying the cross-ref-xx.html section. However sometimes if the SWRL graph is small then the ratio of images looks different. Do you have any suggestions on how to achieve a more proportionate ratio ? I am not that good at css,html and javascript for websites. This is my css and this is an example of how I attach the images to the cross-ref-xx.hml page.

<div class="grid-container">
    <div class="swrl-container">Body
    <img src="swrlrules/rule_R3_AOs_are_transitive_from_device_profile-body.png" style="width: 350px; display: inline-block;" title="SWRL Body">
    </div>
    <div class="swrl-container">Head<img src="swrlrules/rule_R3_AOs_are_transitive_from_device_profile-head.png" style="width: 350px; display: inline-block;" title="SWRL Head">
    </div>
</div>

Big graph

Small graph

vChavezB · 2023-12-17T13:11:17Z

After some chat gpt and debugging I have made a javascript to scale the swrl images so they have the same ratio.

This is not part of the PR but just wanted to give some ideas on how this might look integrated into Widoco :)

dgarijo · 2023-12-18T12:12:04Z

@vChavezB thanks for your edits. I guess that if you want to add images for rules, we can introduce a metadata property for annotating them in the ontology, so you don't need to add them manually. Something like widoco:hasRuleImage, or something like that. I am bringing this up in case this helps things.
Are you done with your edits? I see that you are still committing to this PR.

vChavezB · 2023-12-18T15:05:16Z

Yes, you can do a review now.

About the metadata... Im afk so I will post later some feedback about it.

vChavezB · 2023-12-19T09:51:18Z

Hello @dgarijo

we can introduce a metadata property for annotating them in the ontology

Would you annotate this for each rule? If yes, I do not know if this would work for my use case (i.e. Protege). In protege you can define SWRL rules over the SWRL Tab. As far as I know you can add a name (rdfs:label) and a comment (rdfs:comment). You would need to manually add the widoco:hasRuleImage annotation in the serialized representation of the ontology outside of Protege.

Addes support for correct xslt transformation for TOC and SWRL display. The transformation checks if rdfs:label is defined if not the rules are generically number as they appear in the XML serialization of the ontology.

dgarijo · 2023-12-31T10:07:45Z

Thanks, I opened a new issue #662 to follow up on this. Merging this PR (about time!)

vChavezB mentioned this pull request Dec 11, 2023

Fix parsing of LODE swrl rules #652

Closed

vChavezB force-pushed the swrl-parser-xslt branch from 6b4ef70 to 83e6903 Compare December 11, 2023 01:24

vChavezB force-pushed the swrl-parser-xslt branch from 83e6903 to 23a1539 Compare December 11, 2023 01:43

dgarijo reviewed Dec 11, 2023

View reviewed changes

vChavezB force-pushed the swrl-parser-xslt branch from 23a1539 to 63c4620 Compare December 11, 2023 14:40

vChavezB changed the base branch from master to develop December 11, 2023 14:43

vChavezB force-pushed the swrl-parser-xslt branch from 63c4620 to c805415 Compare December 12, 2023 14:25

vChavezB force-pushed the swrl-parser-xslt branch 2 times, most recently from fc4bdc7 to 8c9838d Compare December 12, 2023 17:36

vChavezB force-pushed the swrl-parser-xslt branch 5 times, most recently from c07e58f to ad1d537 Compare December 16, 2023 10:45

vChavezB force-pushed the swrl-parser-xslt branch from ad1d537 to f29e5aa Compare December 18, 2023 00:42

Fix SWRL parsing

badb45b

Addes support for correct xslt transformation for TOC and SWRL display. The transformation checks if rdfs:label is defined if not the rules are generically number as they appear in the XML serialization of the ontology.

vChavezB force-pushed the swrl-parser-xslt branch from f29e5aa to badb45b Compare December 20, 2023 00:09

dgarijo mentioned this pull request Dec 31, 2023

Add new property for rule images (widoco:hasRuleImage) #662

Open

dgarijo merged commit 95387b0 into dgarijo:develop Dec 31, 2023
4 checks passed

dgarijo mentioned this pull request Dec 31, 2023

SWRL rules dont appear. #651

Closed

@@ @@ -1,6 +1,7 @@ @@
               <?xml version="1.0" encoding="UTF-8"?>
               <!--
               Copyright (c) 2010-2013, Silvio Peroni <[email protected]>
+              Copyright (C) 2023, Victor Chavez <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix SWRL parsing #654

Fix SWRL parsing #654

vChavezB commented Dec 11, 2023 •

edited

Loading

vChavezB commented Dec 11, 2023 •

edited

Loading

vChavezB commented Dec 11, 2023

dgarijo commented Dec 11, 2023

dgarijo Dec 11, 2023

vChavezB Dec 11, 2023

vChavezB commented Dec 11, 2023 •

edited

Loading

vChavezB commented Dec 11, 2023

vChavezB commented Dec 11, 2023

dgarijo commented Dec 11, 2023

dgarijo commented Dec 11, 2023

vChavezB commented Dec 11, 2023

dgarijo commented Dec 11, 2023

vChavezB commented Dec 11, 2023

dgarijo commented Dec 12, 2023

vChavezB commented Dec 12, 2023

vChavezB commented Dec 12, 2023

vChavezB commented Dec 16, 2023 •

edited

Loading

vChavezB commented Dec 17, 2023

dgarijo commented Dec 18, 2023

vChavezB commented Dec 18, 2023

vChavezB commented Dec 19, 2023 •

edited

Loading

dgarijo commented Dec 31, 2023

Fix SWRL parsing #654

Fix SWRL parsing #654

Conversation

vChavezB commented Dec 11, 2023 • edited Loading

TOC

Contents

vChavezB commented Dec 11, 2023 • edited Loading

vChavezB commented Dec 11, 2023

dgarijo commented Dec 11, 2023

dgarijo Dec 11, 2023

Choose a reason for hiding this comment

vChavezB Dec 11, 2023

Choose a reason for hiding this comment

vChavezB commented Dec 11, 2023 • edited Loading

vChavezB commented Dec 11, 2023

vChavezB commented Dec 11, 2023

dgarijo commented Dec 11, 2023

dgarijo commented Dec 11, 2023

vChavezB commented Dec 11, 2023

dgarijo commented Dec 11, 2023

vChavezB commented Dec 11, 2023

dgarijo commented Dec 12, 2023

vChavezB commented Dec 12, 2023

vChavezB commented Dec 12, 2023

vChavezB commented Dec 16, 2023 • edited Loading

Big graph

Small graph

vChavezB commented Dec 17, 2023

dgarijo commented Dec 18, 2023

vChavezB commented Dec 18, 2023

vChavezB commented Dec 19, 2023 • edited Loading

dgarijo commented Dec 31, 2023

vChavezB commented Dec 11, 2023 •

edited

Loading

vChavezB commented Dec 11, 2023 •

edited

Loading

vChavezB commented Dec 11, 2023 •

edited

Loading

vChavezB commented Dec 16, 2023 •

edited

Loading

vChavezB commented Dec 19, 2023 •

edited

Loading