Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a property has an union domain, it won't appear in the domain of the respective classes #379

Open
dgarijo opened this issue Mar 31, 2020 · 6 comments
Assignees
Milestone

Comments

@dgarijo
Copy link
Owner

dgarijo commented Mar 31, 2020

For example:
name is a property and its domain is (Person or Dog).
the name property will appear with 2 domains listed: Person or Dog.
However in "Person" it won't appear in the "is in domain of" field. Technically speaking it is correct because the domain is the union. But in practice, the documentation should show the property as "in domain" of both classes. (Or maybe with a remark stating that is part of a union domain).

@vtoure
Copy link

vtoure commented Jan 7, 2021

This would be a great (and needed) feature for my use case. Is there a plan or priority put to implement it?
Thanks!

@dgarijo
Copy link
Owner Author

dgarijo commented Jan 7, 2021

Hi @vtoure,
in https://github.com/dgarijo/Widoco/milestones you can see the next issues I will be tackling in WIDOCO. I will come back to this one, but it will have to wait for a bit, as it requires editing the lode transformations

@dgarijo dgarijo added this to the v1.4.15 milestone May 24, 2021
@dgarijo
Copy link
Owner Author

dgarijo commented May 24, 2021

Ontology to test this out: http://id.e-science.pl/ontologies/azonOnto.ttl

@Murloc6
Copy link
Contributor

Murloc6 commented Feb 8, 2024

I opened a PR to fix this, :) I would appreciate it if it can be in the next release since I needed to add a custom temp fix to my project. How can I help to do so ?
Thank you for this wonderful projet :)

@dgarijo
Copy link
Owner Author

dgarijo commented Feb 8, 2024

Thanks @Murloc6 !!
Will try to do a merge soon. Please change the target branch of your PR to the develop branch.

Murloc6 added a commit to logilab/Widoco that referenced this issue Feb 8, 2024
@dgarijo
Copy link
Owner Author

dgarijo commented Feb 8, 2024

Fixed in #679, I just need to build a test to verify everything works :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants