Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottle Missing Sample ID in BTL file #173

Closed
upsonp opened this issue Jul 10, 2024 · 0 comments
Closed

Bottle Missing Sample ID in BTL file #173

upsonp opened this issue Jul 10, 2024 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@upsonp
Copy link
Collaborator

upsonp commented Jul 10, 2024

Loading the DY16902 mission, DY169a174.BTL has a bottle fired out of sequence, it has a bottle position of 24, but then no sample ID (because it wasn't sampled).

This causes a ValueError in the ctd parser, but also the error isn't reported to the user and Dart doesn't load the other samples from the file:

ERROR 2024-07-10 07:29:06,554 form_btl_load form_btl_load.py 271 load_ctd_file cannot convert float NaN to integer
Traceback (most recent call last):
  File "D:\Gov\projects\python\dart\core\form_btl_load.py", line 269, in load_ctd_file
    ctd.read_btl(ctd_mission, ctd_file_path)
  File "D:\Gov\projects\python\dart\core\parsers\ctd.py", line 494, in read_btl
    process_data(event=event, data_frame=data_frame, column_headers=col_headers)
  File "D:\Gov\projects\python\dart\core\parsers\ctd.py", line 376, in process_data
    bottle_id = int(row[1]['bottle_'])
                ^^^^^^^^^^^^^^^^^^^^^^
ValueError: cannot convert float NaN to integer
@upsonp upsonp added the bug Something isn't working label Jul 10, 2024
@upsonp upsonp added this to the 4.0.0 milestone Jul 10, 2024
upsonp added a commit to upsonp/dart that referenced this issue Jul 10, 2024
upsonp added a commit that referenced this issue Jul 10, 2024
Fixed issue with missing sample id in btl file #173
@upsonp upsonp closed this as completed Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant