Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Validation - Position #150

Closed
upsonp opened this issue Jun 11, 2024 · 0 comments
Closed

Event Validation - Position #150

upsonp opened this issue Jun 11, 2024 · 0 comments
Labels
enhancement New feature or request Proposal Feature to be discussed with Dart Steering Commetting
Milestone

Comments

@upsonp
Copy link
Collaborator

upsonp commented Jun 11, 2024

When validating an event at sea the validation will expect an event to have at least one action and that action must have at least a date and a sounding, but Dart doesn't validate that the event has a position.

The easiest place to fix a missing position is going to be at sea when data is being loaded, it'll be much harder to fix once users get to the BioChem loading process #147

In the core.validation.validate_event() function when checking an action exists and that it has a date and depth also check for a position.

@upsonp upsonp added enhancement New feature or request Proposal Feature to be discussed with Dart Steering Commetting labels Jun 11, 2024
@upsonp upsonp added this to the 3.3.0 milestone Jun 11, 2024
upsonp added a commit to upsonp/dart that referenced this issue Jun 17, 2024
@upsonp upsonp closed this as completed Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Proposal Feature to be discussed with Dart Steering Commetting
Projects
None yet
Development

No branches or pull requests

1 participant