Pass on random generator to KDE resample method #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the random generator available in the KDE propose method for resampling, in order to have reproducible emcee runs.
|
The test assert np.abs(np.mean(samples) - mjd) < 10 * sigma / np.sqrt(len(samples))fails for certain np.random states. What is the preferred way to solve this?
|
|
Thanks! |
|
You're welcome. Would it be possible to get a new version released including this fix? |
|
I'm going to wait until we get that test failure figured out (#438) then definitely! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the random generator in the
get_proposalmethod for theKDEMoveis not used when taking samples from the KDE. This is problematic since we cannot run emcee in a reproducible way. This PR fixes this by passing on the random generator to the KDE resampling method, so that sampling is reproducible.