Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ReturnTypeWillChange attributes #40

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Implement ReturnTypeWillChange attributes #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ jobs:
- php: '8.0'
coverage: false
composer-flags: '--ignore-platform-req=php'
- php: '8.1'
coverage: false
composer-flags: '--ignore-platform-req=php'

steps:
- uses: actions/checkout@v2
Expand All @@ -51,9 +54,9 @@ jobs:

- run: echo "::add-matcher::${{ runner.tool_cache }}/phpunit.json"

- name: "Use PHPUnit 9.3+ on PHP 8"
- name: "Use PHPUnit 9.3+ on PHP 8.0 & PHP 8.1"
run: composer require --no-update --dev phpunit/phpunit:^9.3
if: "matrix.php == '8.0'"
if: "matrix.php == '8.0' || matrix.php == '8.1'"

- run: composer update --no-progress ${{ matrix.composer-flags }}

Expand Down
4 changes: 4 additions & 0 deletions src/Data.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ public function export(): array
/**
* {@inheritdoc}
*/
#[\ReturnTypeWillChange]
public function offsetExists($key)
{
return $this->has($key);
Expand All @@ -212,6 +213,7 @@ public function offsetExists($key)
/**
* {@inheritdoc}
*/
#[\ReturnTypeWillChange]
public function offsetGet($key)
{
return $this->get($key, null);
Expand All @@ -222,6 +224,7 @@ public function offsetGet($key)
*
* @param string $key
*/
#[\ReturnTypeWillChange]
public function offsetSet($key, $value)
{
$this->set($key, $value);
Expand All @@ -230,6 +233,7 @@ public function offsetSet($key, $value)
/**
* {@inheritdoc}
*/
#[\ReturnTypeWillChange]
public function offsetUnset($key)
{
$this->remove($key);
Expand Down