Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement more-specific exceptions #20

Merged
merged 3 commits into from
Sep 25, 2020

Conversation

colinodell
Copy link
Contributor

This PR introduces two new types of exceptions to help developers better differentiate between generic errors and those specific to certain invalid uses of this library.

@simensen
Copy link
Member

@colinodell Looks like we need a rebase here. Your other open PRs have all been merged.

@colinodell colinodell force-pushed the better-exceptions branch 2 times, most recently from 932594f to fd416c7 Compare September 25, 2020 13:14
@colinodell
Copy link
Contributor Author

Rebase completed. Please note that #23 should be merged first.

@simensen simensen merged commit 5b2ba69 into dflydev:master Sep 25, 2020
@colinodell colinodell deleted the better-exceptions branch September 26, 2020 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants