representation.py: better assertion errors #354
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced two simple
assert
s with detailed error messages about what's gone wrong.Related Issue
#353
Motivation and Context
I was working on a robot with 131 links and got an assertion error from representation.py, on this line:
The generic assertion error and call stack was not helpful for understanding what went wrong or which of the 131 links was causing the problem. I had to look at the source code to better understand the problem, and then replace the simple
assert
with a more detailedAssertionError
so I would know which link was causing the error.While I was at it, I also added a more detailed
AssertionError
for the case where themeshname
is None or not a string.How Has This Been Tested?
I used the new
AssertionError
forself.input_type
to identify which link in the robot was causing the issue.Types of changes
Checklist: