Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export-Excel -FreezeTopRow with -Title #795

Closed
patware opened this issue Mar 1, 2020 · 6 comments
Closed

Export-Excel -FreezeTopRow with -Title #795

patware opened this issue Mar 1, 2020 · 6 comments

Comments

@patware
Copy link

patware commented Mar 1, 2020

Let me start with thank you.

When using the FreezeTopRow, Export-Excel it freezes the excel row 1 of the sheet. But, when combined with a -Title "Foo", row 1 has the description "Foo" and the table actually starts at row 2.

I believe that the FreezeTopRow should act on the table's header.

Same for
-FreezeTopRow
-FreezeTopRowFirstColumn

Note 1: I understand this could be a breaking change
Note 2: I'm aware I can use the FreezePane instead

@jhoneill
Copy link

jhoneill commented Mar 1, 2020

You're right. It should freeze the header, but it actually freezes row 1.
Alternatively. "Top Row" should only mean one row, and there is a problem if someone specifies start at row 10, do we keep that row and the 9 above it visible ?

Technically it is a breaking change but I think it is unlikely that anyone relies on freezing the title and not the headers.
@dfinke - thoughts ? Change the existing switch; add -freezeHeader or leave as is ?

@dfinke
Copy link
Owner

dfinke commented Mar 1, 2020

Fixing the switch. Don't know how many this will break. Don't remember seeing lots of traffic on this issue.

@jhoneill
Copy link

jhoneill commented Mar 3, 2020

Do you mean you are fixing it, or you think that's the best way (in which case I'll do it :-) )

@dfinke
Copy link
Owner

dfinke commented Mar 3, 2020

Sorry :). Thought it was the best way. Not sure it needs fixing, I wouldn't be able to get to it till the weekend, maybe, but there are a couple things that can be published.

Please have at it :)

@jhoneill
Copy link

jhoneill commented Mar 3, 2020

OK, I'll take it. I have a nice extra example to go in the next PR too. Covert Nunit output from pester to a spreadsheet.

@dfinke
Copy link
Owner

dfinke commented Mar 3, 2020

Sounds really good. I'm guessing different than the, test this example?

jhoneill added a commit to jhoneill/ImportExcel that referenced this issue Mar 16, 2020
dfinke added a commit that referenced this issue Mar 16, 2020
fix #802 and #795. Extra examples including pester-xlsx
@dfinke dfinke closed this as completed Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants