Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Node::load and Node::save #107

Merged
merged 2 commits into from
Jul 21, 2023
Merged

test: Node::load and Node::save #107

merged 2 commits into from
Jul 21, 2023

Conversation

ielashi
Copy link
Contributor

@ielashi ielashi commented Jul 21, 2023

A new version of Node will soon be introduced, and this commit paves the way for that by:

  1. Moving the logic of load and store into a separate file (v1.rs)
  2. Adding a proptest for load and store to ensure we don't introduce regressions

ielashi added 2 commits July 20, 2023 16:13
We will be introducing a new version of `Node` to accommodate varying
node sizes. `v1.rs` encapsulates the logic that's specific to V1, and
`v2.rs` will be introduced in an upcoming commit containing V2-specific
logic.
@ielashi ielashi requested review from a team and roman-kashitsyn as code owners July 21, 2023 11:18
@ielashi ielashi changed the title refactor + test: Node::load and Node::save test: Node::load and Node::save Jul 21, 2023
@ielashi ielashi merged commit 693b071 into main Jul 21, 2023
@ielashi ielashi deleted the ielashi/node_refactor__3 branch July 21, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants