feat: accept more ways to specify cycle and e8s amounts #3452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THLO
reviewed
Nov 22, 2023
THLO
reviewed
Nov 22, 2023
THLO
reviewed
Nov 22, 2023
THLO
reviewed
Nov 22, 2023
THLO
reviewed
Nov 22, 2023
THLO
approved these changes
Nov 22, 2023
Co-authored-by: Thomas Locher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are more ways to specify cycles amounts than just using plain digits. This PR adds support for
_as thousand separator, plus shorthands such as5kor3TCfor cycle, trillion cycle, and e8s amounts.How Has This Been Tested?
Added unit tests
Checklist: