feat(frontend): Add USD balance in Hero for token page #2976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let usdBalance: number | undefined; | ||
| $: usdBalance = nonNullish($token) | ||
| ? calculateTokenUsdBalance({ | ||
| token: $token, |
There was a problem hiding this comment.
Maybe we should pass the token as property? Easier to refactor when we move away from the global store?
|
|
||
| {#if $erc20UserTokensInitialized && nonNullish(tokenSymbol)} | ||
| <span class="opacity-100">{$tokenSymbol}</span> | ||
| <span class="text-xl font-bold" class:opacity-50={usdBalance ?? 0 === 0}> |
There was a problem hiding this comment.
What do you think about extracting this into a separate component? Like TokenUsdBalance or something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We include the USD balance in the
Hero, right below the token balance, when the user is in the transaction page.Note that when the token has no USD price, we treat the USD balance in the same way, showing
$-instead of zero.Results