Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(frontend): generalize usage of HowToConvertEthereumModal #2141

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

refactor(frontend): generalize usage of HowToConvertEthereumModal #2141

wants to merge 1 commit into from

Conversation

AntonioVentilii-DFINITY
Copy link
Collaborator

Motivation

Since we are going to re-use InfoEthereum, we make the children component dependent on its prop. For example, we pass twinToken to the modals and we use it in cascade.

Changes

  • Pass twinToken to HowToConvertEthereumModal.
  • Adapt usage in HowToConvertEthereumModal.
  • Pass twinTokenSymbol to HowToConvertEthereumInfo.
  • Adapt usage in HowToConvertEthereumInfo and IcReceiveCkEthereumModal.

Tests

No changes in local replica.

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY requested a review from a team as a code owner August 27, 2024 12:29
@peterpeterparker
Copy link
Member

Given what we discussed here, this PR should also be turned into a draft for now?

@AntonioVentilii-DFINITY AntonioVentilii-DFINITY marked this pull request as draft September 3, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterpeterparker peterpeterparker Awaiting requested review from peterpeterparker

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntonioVentilii-DFINITY @peterpeterparker