Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] tx details pointing to /ethereum/ instead of /sepoliaeth/ #3351

Open
marc0olo opened this issue Nov 5, 2024 · 1 comment
Open

[BUG] tx details pointing to /ethereum/ instead of /sepoliaeth/ #3351

marc0olo opened this issue Nov 5, 2024 · 1 comment
Assignees
@StefanBerger-DFINITY
Labels
bug Something isn't working

Comments

@marc0olo
Copy link
Member

marc0olo commented Nov 5, 2024

Describe the bug
When converting SepoliaETH into ckSepoliaETH, the modal in the tx details contains links to the wrong token for the following outputs:

  • Transaction ID
  • To

To Reproduce

  • convert SepoliaETH into ckSepoliaETH
  • open the tx detail modal

Expected behavior
The dashboard link to Transaction ID and To should be correct.
@marc0olo marc0olo added the bug Something isn't working label Nov 5, 2024
@StefanBerger-DFINITY StefanBerger-DFINITY self-assigned this Nov 6, 2024
@StefanBerger-DFINITY
Copy link

Hi Marco
Thanks for letting us know. This will be addressed asap and should be fixed in next week's release, and I will update this issue accordingly.

@loki344 loki344 mentioned this issue Nov 8, 2024
Merged
loki344 added a commit that referenced this issue Nov 11, 2024
@loki344
fix(frontend): fix explorer url for testnet ck tokens (#3414)
1149c27 
# Motivation

Problem: ckSepolia tokens are pointed to the 'ethereum' dashboard of
icp. ckSepolia tokens have the env === 'mainnet' which causes the false
evaluation of the explorer url. We want to check for env === 'testnet'
OR the icrc testnet tokens

see also: #3351

# Changes

- add condition for testnet tokens
- add tests for explorer url

# Tests
before


https://github.com/user-attachments/assets/329ef682-136b-4ed9-8d0b-7b2574f70117

after


https://github.com/user-attachments/assets/88509020-d142-4d7c-9160-9840ebb1658e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StefanBerger-DFINITY StefanBerger-DFINITY

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marc0olo @StefanBerger-DFINITY