Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nns missing rewards indicator #6068

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Conversation

mstrasinskis
Copy link
Contributor

@mstrasinskis mstrasinskis commented Dec 23, 2024

Motivation

When the user has Nns neurons that haven’t been active and are set to start losing rewards in 30 days or less, a red circle needs to be displayed next to the “Neuron Staking” sidebar item and on in the Neuron Staking page table to indicate that action is required.
In this PR, we introduce the indicator component, which will be used in the navigation menu and the projects table.

Changes

  • New NnsNeuronsMissingRewardsBadge component.

Tests

  • Added.

Todos

  • Add entry to changelog (if necessary).
    Not necessary.

@mstrasinskis mstrasinskis marked this pull request as ready for review December 23, 2024 09:25
@mstrasinskis mstrasinskis requested a review from a team as a code owner December 23, 2024 09:25
Copy link
Contributor

@yhabib yhabib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a small comment

@mstrasinskis mstrasinskis added this pull request to the merge queue Dec 23, 2024
Merged via the queue into main with commit f84b0fc Dec 23, 2024
31 checks passed
@mstrasinskis mstrasinskis deleted the nns-missing-rewards-indicator branch December 23, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants