Deprecate voting power #6058
Merged
Deprecate voting power #6058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstrasinskis
commented
Dec 20, 2024
frontend/src/tests/lib/components/neuron-detail/NnsNeuronVotingPowerSection.spec.ts
Show resolved
Hide resolved
yhabib
reviewed
Dec 20, 2024
yhabib
reviewed
Dec 20, 2024
Co-authored-by: Yusef Habib <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
New fields representing the voting power of a neuron have recently been introduced to the governance canister (https://github.com/dfinity/ic/blob/release-2024-12-06_03-16-base/rs/nns/governance/canister/governance.did#L741-L743), and the original votingPower field has been marked as deprecated. With this PR,
votingPoweris replaced bydecidedVotingPower, which more accurately reflects the current voting power state of a neuron.Note: The new fields are marked as optional to maintain backward compatibility of the type, but they are expected to always be provided.
Changes
NeuronInfo.votingPowerwithNeuronInfo.decidingVotingPower.Tests
Todos
Not necessary.