Extract HeadingSubtitleWithUsdValue #6037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
# Motivation Want to show the stake in USD on the neuron details page similar to how we show the account balance on the wallet page. This PR does it for NNS neurons. Another PR will do SNS neurons. And a third PR will make sure token prices are loaded when the neuron page is deep linked. # Changes 1. Use `HeadingSubtitleWithUsdValue` which was extracted in #6037 in `NnsNeuronPageHeading`. Some of the slot content is temporarily duplicate between with and without feature flag. # Tests 1. Unit tests added. 2. Manually at https://qsgjb-riaaa-aaaaa-aaaga-cai.dskloet-ingress.devenv.dfinity.network/neuron/?u=qsgjb-riaaa-aaaaa-aaaga-cai&neuron=7894867686608507388 # Todos - [ ] Add entry to changelog (if necessary). not yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
On the wallet page, we show the account balance in USD in the heading subtitle.
We want to do something similar on the NNS and SNS neuron details page.
To make this easier, in this PR we extract a component to show a heading subtitle with USD value.
Changes
HeadingSubtitleWithUsdValuefromWalletPageHeading.HeadingSubtitleWithUsdValueinWalletPageHeadingifENABLE_USD_VALUESis enabled.Tests
Todos
not necessary