-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NNS1-3485: new LinkToReporting component #5965
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhabib
changed the title
NNS1-3485: new LinkToReporting component for the AccountMenu
NNS1-3485: new LinkToReporting component
Dec 10, 2024
1 task
yhabib
force-pushed
the
NNS1-3485/reporting-account-menu-link
branch
from
December 10, 2024 09:41
74fd140
to
cf25127
Compare
mstrasinskis
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
# Motivation This new page will display all reporting functionalities currently found in the `AccountMenu`. This first iteration introduces the page without any logic. Subsequent pull requests will migrate the Export components from the `AccountMenu` to this page. # Changes - New Reporting page # Tests - Unit tests for the route's layout and page - Unit tests for the page # Todos - [ ] Add entry to changelog (if necessary). Not yet Next PR: #5965
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The new reporting page will be accessible through the
AccountMenu
. This component, which is behind a feature flag, redirects users to this page as long as they are logged in.Deployed here
Changes
LinkToReporting
componentAccountMenu
Tests
AccountMenu
Todos
Not necessary
Prev. PR: #5964