Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NNS1-3485: new LinkToReporting component #5965

Merged
merged 9 commits into from
Dec 10, 2024

Conversation

yhabib
Copy link
Contributor

@yhabib yhabib commented Dec 10, 2024

Motivation

The new reporting page will be accessible through the AccountMenu. This component, which is behind a feature flag, redirects users to this page as long as they are logged in.

Deployed here

Changes

  • New LinkToReporting component
  • Added new component to the AccountMenu

Tests

  • Unit tests for the component within the AccountMenu

Todos

  • Add entry to changelog (if necessary).
    Not necessary

Prev. PR: #5964

@yhabib yhabib changed the title NNS1-3485: new LinkToReporting component for the AccountMenu NNS1-3485: new LinkToReporting component Dec 10, 2024
@yhabib yhabib force-pushed the NNS1-3485/reporting-account-menu-link branch from 74fd140 to cf25127 Compare December 10, 2024 09:41
@yhabib yhabib marked this pull request as ready for review December 10, 2024 09:57
@yhabib yhabib requested a review from a team as a code owner December 10, 2024 09:57
Copy link
Contributor

@mstrasinskis mstrasinskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

github-merge-queue bot pushed a commit that referenced this pull request Dec 10, 2024
# Motivation

This new page will display all reporting functionalities currently found
in the `AccountMenu`.
This first iteration introduces the page without any logic. Subsequent
pull requests will migrate the Export components from the `AccountMenu`
to this page.

# Changes

- New Reporting page

# Tests

- Unit tests for the route's layout and page
- Unit tests for the page

# Todos

- [ ] Add entry to changelog (if necessary).
Not yet

Next PR: #5965
Base automatically changed from NNS1-3485/new-report-page to main December 10, 2024 11:18
@yhabib yhabib enabled auto-merge December 10, 2024 11:27
@yhabib yhabib added this pull request to the merge queue Dec 10, 2024
Merged via the queue into main with commit fc24286 Dec 10, 2024
30 checks passed
@yhabib yhabib deleted the NNS1-3485/reporting-account-menu-link branch December 10, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants