Add error state to icpSwapUsdPricesStore #5953
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We loaded token prices from ICP Swap.
If this results in an error, we want to show
-/-
as USD values and show an error state with tooltip.There can be 2 reasons why there is an error:
In this PR we add an extra possible
"error"
value to the derived storeicpSwapUsdPricesStore
and use it if parsing the ICP Swap data fails.Changes
icpSwapUsdPricesStore
to"error"
if there is an error when parsing ICP Swap tickers or if there is an unreasonable value.Tests
Unit tests added.
Todos
not yet