NNS1-3480: New util function mapIcpTransactionToReport #5895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhabib
changed the title
yhabib
commented
Dec 2, 2024
yhabib
force-pushed
the
NNS1-3480/new-map-transactions
branch
from
1c9f003 to
9df154a
Compare
dskloetd
reviewed
Dec 2, 2024
yhabib
changed the title
dskloetd
approved these changes
Dec 3, 2024
1 task
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
# Motivation To generate a Csv file with transaction information shows in the `/wallet` page of an account. It can be tested [here](https://qsgjb-riaaa-aaaaa-aaaga-cai.yhabib-ingress.devenv.dfinity.network/) # Changes - New component to create and initialize the download of a CSV file containing information about all transactions for all user accounts. # Tests - Component Unit Tests # Todos - [ ] Add entry to changelog (if necessary). Not necessary Prev. PR: #5895 | Next PR: #5926
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a follow-up to #5891. It introduces a new function,
mapIcpTransactionToReport, which provides information for the report.A third PR will follow to extract smaller functions from
mapIcpTransactionToReportandmapIcpTransactionToUIfor reuse between both.Changes
mapIcpTransactionToReportfunctionTests
Todos
Not necessary
Prev. PR: #5891