Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NNS1-2851: Remove wallet-tokens services #4466

Merged
merged 3 commits into from
Feb 12, 2024
Merged

NNS1-2851: Remove wallet-tokens services #4466

merged 3 commits into from
Feb 12, 2024

Conversation

lmuntaner
Copy link
Contributor

@lmuntaner lmuntaner commented Feb 12, 2024 •
edited
Loading

Motivation

Unify wallet implementation.

In this PR, remove the wallet-tokens service loadToken and related files.

Changes

  • Remove wallet-ledger api getToken.
  • Use loadIcrcToken in loadCkBTCTokens.
  • Set certified as optional in loadIcrcToken to better match usage of removed loadToken.
  • Remove wallet-tokens services.

Tests

  • Remove mocks to getToken in wallet-ledger.api and mock loadIcrcToken in icrc-ledger.api.
  • Change test for loadIcrcToken without certified parameter.

Todos

  • Add entry to changelog (if necessary).

Not necessary.

@lmuntaner Graphite App
Copy link
Contributor Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@lmuntaner lmuntaner marked this pull request as ready for review February 12, 2024 15:01
@lmuntaner lmuntaner requested a review from dskloetd February 12, 2024 15:01
@lmuntaner Graphite App
Copy link
Contributor Author

@dskloetd please review

dskloetd
dskloetd reviewed Feb 12, 2024
View reviewed changes
Copy link
Contributor

@dskloetd dskloetd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

frontend/src/lib/services/wallet-tokens.services.ts Outdated Show resolved Hide resolved
@lmuntaner lmuntaner force-pushed the 02-12-NNS1-2851_Remove_wallet-tokens_services branch from 33ba73a to b382a35 Compare February 12, 2024 16:11
@lmuntaner Graphite App
Copy link
Contributor Author

@dskloetd can you approve then?

@lmuntaner lmuntaner requested a review from dskloetd February 12, 2024 16:13
dskloetd
dskloetd approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@dskloetd dskloetd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops I thought I had

@lmuntaner lmuntaner added this pull request to the merge queue Feb 12, 2024
Merged via the queue into main with commit d1525fc Feb 12, 2024
49 checks passed
@lmuntaner lmuntaner deleted the 02-12-NNS1-2851_Remove_wallet-tokens_services branch February 12, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dskloetd dskloetd dskloetd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmuntaner @dskloetd