Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: Work around images not loading #3344

Merged
merged 2 commits into from
Sep 21, 2023
Merged

E2E: Work around images not loading #3344

merged 2 commits into from
Sep 21, 2023

Conversation

dskloetd
Copy link
Contributor

Motivation

We have an e2e test that tests that images load.
Sometimes images don't load and the test times out:
https://github.com/dfinity/nns-dapp/actions/runs/6245207559?pr=3337

I'm not sure why they don't always load on CI but let's retry the test when they don't.

Changes

  1. Set a timeout on waiting for images to be loaded.
  2. Retry the test up to 2 times when it fails.

Tests

Still pass, hopefully less flaky.

Todos

  • Add entry to changelog (if necessary).
    not necessary

@dskloetd dskloetd marked this pull request as ready for review September 21, 2023 09:16
@dskloetd dskloetd requested a review from lmuntaner September 21, 2023 09:16
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dskloetd dskloetd added this pull request to the merge queue Sep 21, 2023
Merged via the queue into main with commit 0e3aa5a Sep 21, 2023
38 checks passed
@dskloetd dskloetd deleted the kloet/e2e-images branch September 21, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants