Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GIX-1890: Check transaction fee disburse maturity #3331

Merged
merged 9 commits into from
Sep 19, 2023
Merged

GIX-1890: Check transaction fee disburse maturity #3331

merged 9 commits into from
Sep 19, 2023

Conversation

lmuntaner
Copy link
Contributor

@lmuntaner lmuntaner commented Sep 18, 2023 •
edited
Loading

Motivation

Users can't disburse maturity if less than transaction fee.

It's just used as a minimum, it's not that a fee is applied to the amount.

Changes

  • A new prop disabledText in NeuronSelectPercentage.
  • New prop in DisburseMaturityModal. Check to enable or disable first screen.
  • New neuron util minimumAmountToDisburseMaturity.
  • Rename SPAWN_VARIANCE_PERCENTAGE to MATURITY_MODULATION_VARIANCE_PERCENTAGE.

Tests

  • Add test case in SnsDisburseMaturityModal.spec.
  • Add test for new neuron util.

Todos

  • Add entry to changelog (if necessary).
    Already covered by disburse maturity entry.

@lmuntaner
Copy link
Contributor Author

New UX:

Screen.Recording.2023-09-18.at.16.44.01.mov

@lmuntaner lmuntaner force-pushed the GIX-1890_LM_check-transaction-fee-disburse-maturity branch from 86b57fd to b2c9a94 Compare September 18, 2023 15:02
@lmuntaner lmuntaner requested a review from dskloetd September 18, 2023 15:02
@lmuntaner
Copy link
Contributor Author

@dskloetd please review

@lmuntaner lmuntaner enabled auto-merge September 18, 2023 15:07
@lmuntaner lmuntaner disabled auto-merge September 18, 2023 15:08
@lmuntaner lmuntaner force-pushed the GIX-1890_LM_check-transaction-fee-disburse-maturity branch from 6ebe1f7 to 8ceaec7 Compare September 19, 2023 05:37
@lmuntaner lmuntaner requested a review from dskloetd September 19, 2023 05:38
@lmuntaner
Copy link
Contributor Author

lmuntaner commented Sep 19, 2023 •
edited
Loading

@dskloetd ready for another review

I have applied the same minimum when disabling the button "Disburse Maturity" also in this PR. Otherwise, I felt the PR left the main branch in a buggy state.

@lmuntaner lmuntaner force-pushed the GIX-1890_LM_check-transaction-fee-disburse-maturity branch from 22d8fdf to a6b4a51 Compare September 19, 2023 09:58
@lmuntaner lmuntaner requested a review from dskloetd September 19, 2023 09:59
@lmuntaner
Copy link
Contributor Author

@dskloetd ready for another review

@lmuntaner lmuntaner added this pull request to the merge queue Sep 19, 2023
Merged via the queue into main with commit 277d7ab Sep 19, 2023
38 checks passed
@lmuntaner lmuntaner deleted the GIX-1890_LM_check-transaction-fee-disburse-maturity branch September 19, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dskloetd dskloetd dskloetd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmuntaner @dskloetd