Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIX-1890: Check tx fee to disable disburse maturity button #3329

Merged
merged 5 commits into from
Sep 18, 2023

Conversation

lmuntaner
Copy link
Contributor

@lmuntaner lmuntaner commented Sep 18, 2023

Motivation

Check the fee to enable the disburse maturity button.

Changes

  • DisburseMaturityButton: Change prop to disabledText.
  • Add prop feeE8s to SnsDisburseMaturityButton
  • Add prop feeE8s to SnsAvailableMaturityItemAction.
  • Add prop feeE8s to SnsNeuronMaturitySection.
  • New sns neuron util hasEnoughMaturityToDisburse
  • Rename hasEnoughMaturityToStakeOrDisburse to hasEnoughMaturityToStake
  • Use new util hasEnoughMaturityToDisburse and new prop disabledText in SnsDisburseMaturityButton.
  • Change copy in "disburse_maturity_disabled_tooltip" i18n key.

Tests

  • Adapt tests to new props.
  • Adapt tests to disabledText prop name.
  • Change test case in SnsDisburseMaturityButton.spec to check agains a maturity less than fee.
  • New test case in SnsAvailableMaturityItemAction

Todos

  • Add entry to changelog (if necessary).
    Not worth an entry. Covered by disburse maturity entry.

@lmuntaner lmuntaner requested a review from dskloetd September 18, 2023 13:05
@lmuntaner
Copy link
Contributor Author

New UI:

Screenshot 2023-09-18 at 14 26 57

@lmuntaner
Copy link
Contributor Author

@dskloetd please review

@lmuntaner lmuntaner requested a review from dskloetd September 18, 2023 14:03
@lmuntaner
Copy link
Contributor Author

@dskloetd ready for another review

@lmuntaner lmuntaner enabled auto-merge September 18, 2023 15:08
@lmuntaner lmuntaner added this pull request to the merge queue Sep 18, 2023
Merged via the queue into main with commit c5114aa Sep 18, 2023
38 checks passed
@lmuntaner lmuntaner deleted the GIX-1890_LM_disable-button-check-fee branch September 18, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants