Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Setup SnsDisburseMaturityModal.spec #3328

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Fix: Setup SnsDisburseMaturityModal.spec #3328

merged 1 commit into from
Sep 18, 2023

Conversation

lmuntaner
Copy link
Contributor

Motivation

Fix broken setup in SnsDisburseMaturityModal test.

Changes

  • SnsDisburseMaturityModal: Use the rootCanisterId passed instead of accessing the derived store of the page store.

Tests

  • Set the tokenStore with a mock token. Fix the expected value.

Todos

  • Add entry to changelog (if necessary).
    Not necessary.

@lmuntaner lmuntaner requested a review from dskloetd September 18, 2023 11:31
@lmuntaner lmuntaner mentioned this pull request Sep 18, 2023
Closed
1 task
@lmuntaner lmuntaner changed the title Fix: Setup SnsDisburseMaturityModal Fix: Setup SnsDisburseMaturityModal.spec Sep 18, 2023
@lmuntaner lmuntaner added this pull request to the merge queue Sep 18, 2023
Merged via the queue into main with commit 0a74aed Sep 18, 2023
@lmuntaner lmuntaner deleted the fix_LM_wrong-test-setup-disburse-modal branch September 18, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dskloetd dskloetd dskloetd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmuntaner @dskloetd