Remove transfer from IcrcTransferParams #3324
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The type
IcrcTransferParams
is defined asThe field
transfer
is only used byexecuteIcrcTransfer
and every other place whereIcrcTransferParams
is used, it's used asOmit<IcrcTransferParams, "transfer">
.Changes
Remove
transfer
fromIcrcTransferParams
and at it back only to the params ofexecuteIcrcTransfer
.Tests
npm run build
npm run check
npm run test
All still pass.
Todos
not necessary