Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make daysToDuration call secondsToDuration #3322

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Make daysToDuration call secondsToDuration #3322

merged 1 commit into from
Sep 18, 2023

Conversation

dskloetd
Copy link
Contributor

Motivation

We want daysToDuration and secondsToDuration to be consistent when the number of seconds is a whole number of times the number of seconds in a day. So there is no need to have 2 completely separate implementations.

Changes

Make daysToDuration call secondsToDuration.

Tests

Existing test coverage is good and passes.

Todos

  • Add entry to changelog (if necessary).
    not necessary

@dskloetd dskloetd marked this pull request as ready for review September 15, 2023 15:39
@dskloetd dskloetd requested a review from lmuntaner September 15, 2023 15:39
lmuntaner
lmuntaner approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dskloetd dskloetd added this pull request to the merge queue Sep 18, 2023
Merged via the queue into main with commit be7f26c Sep 18, 2023
38 checks passed
@dskloetd dskloetd deleted the kloet/seconds-days branch September 18, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmuntaner lmuntaner lmuntaner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dskloetd @lmuntaner