Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update downgrade-upgrade test #3315

Merged
merged 4 commits into from
Sep 13, 2023
Merged

Update downgrade-upgrade test #3315

merged 4 commits into from
Sep 13, 2023

Conversation

bitdivine
Copy link
Member

@bitdivine bitdivine commented Sep 13, 2023

Motivation

The downgrade-upgrade test needs to be able to verify that accounts are preserved across schema updates.

Changes

  • Make it possible to specify a wasm to downgrade to. This way the test can be run with a wasm that implements the future schema S0.early and another, undefined.late that is not yet in production.
  • Get account data; this was already present but commented out as prod did not have account data in a stable, usable form.

Tests

Todos

  • Add entry to changelog (if necessary).

@bitdivine bitdivine requested a review from lmuntaner September 13, 2023 09:20
@bitdivine bitdivine marked this pull request as ready for review September 13, 2023 09:20
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

scripts/nns-dapp/downgrade-upgrade-test Show resolved Hide resolved
@bitdivine bitdivine added this pull request to the merge queue Sep 13, 2023
Merged via the queue into main with commit 72ba2a5 Sep 13, 2023
@bitdivine bitdivine deleted the prod-wasm branch September 13, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants